From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96E0DC433F5 for ; Sat, 23 Apr 2022 05:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yyq8SvxPAjtLFqYEkcx6nzP0JsStlP6J8AMjtmUdxVU=; b=VIFXrk0sspMRnI xJ27Z33OEBtXCoekI0NeJYcr0ms+sPAR6vvJe1HsHse7sJvgvi7bioqnjm4NuH25WssIRk2buxPbz nwiL52LiD7z1IUAU+kqvs70PlQj5l3aMfMMMGZEAg6bJsJigCoKDwybzV/xTN0mqjAN/oII0n0aWr eq1Kf038GD6U9YELP4nMq9f8lo0mfwxx6hk24qWNoh8f2XbBRimke1h9dQgE2FZbomj+9/d6qs/pO AASTAibqg9ubXnH+0jfnKyP/e79qa3N9lP2qooM0AmlRIN6NiO9tF1gNwPWbHupOTHmb089E05Wjy pyQBttBrRTeuW2hmAJ6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ni85v-003SN9-8F; Sat, 23 Apr 2022 05:14:07 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ni85q-003SMm-Dr; Sat, 23 Apr 2022 05:14:02 +0000 Date: Fri, 22 Apr 2022 22:14:02 -0700 From: Christoph Hellwig To: Lu Baolu Cc: Shameer Kolothum , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, robin.murphy@arm.com, jon@solid-run.com, linuxarm@huawei.com, steven.price@arm.com, hch@infradead.org, guohanjun@huawei.com, Sami.Mujawar@arm.com, will@kernel.org, wanghuiqiang@huawei.com Subject: Re: [PATCH v11 1/9] iommu: Introduce a callback to struct iommu_resv_region Message-ID: References: <20220422162907.1276-1-shameerali.kolothum.thodi@huawei.com> <20220422162907.1276-2-shameerali.kolothum.thodi@huawei.com> <03e94ba9-f558-954f-e84b-cd8a9e693aea@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <03e94ba9-f558-954f-e84b-cd8a9e693aea@linux.intel.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 23, 2022 at 10:04:39AM +0800, Lu Baolu wrote: > The generic_iommu_put_resv_regions() itself is a callback. Why bothering > adding another callback from the same iommu driver in it? Or, you are > going to remove the put_resv_regions from the iommu ops? It is a driver method, but these reserved entries are not actually allocated by the driver. And I do have a patch pending removing this driver method that should never have been a driver method, check the iomm list archives for iommu: remove the put_resv_regions method _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel