From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ian Cowan <ian@linux.cowan.aero>,
mripard@kernel.org, mchehab@kernel.org,
gregkh@linuxfoundation.org, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] staging: sunxi: cedrus: centralize cedrus_open exit
Date: Mon, 25 Apr 2022 11:29:30 +0200 [thread overview]
Message-ID: <YmZp+qgSLpT5PP2u@aptenodytes> (raw)
In-Reply-To: <20220425092048.GL2462@kadam>
[-- Attachment #1.1: Type: text/plain, Size: 1176 bytes --]
Hi Dan,
On Mon 25 Apr 22, 12:20, Dan Carpenter wrote:
> On Sat, Apr 23, 2022 at 02:01:11PM -0400, Ian Cowan wrote:
> > Refactor the cedrus_open() function so that there is only one exit to
> > the function instead of 2. This prevents a future change from preventing
> > the mutex from being unlocked after a successful exit.
> >
> > Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
>
> No. You are just making the code ugly and complicated for no reason.
>
> I work in static analysis so I have focussed a lot of attention on
> locking bugs. In real life this theory is totally bogus. Single exit
> paths only cause bugs, they don't prevent bugs.
I'm really surprised by this and honestly it feels a bit dogmatic.
It reminds me of CS teachers telling me "gotos are evil and you must
never use them". In practice there are many situations where they make
the code more readable and don't introduce any significant incertainty.
In this instance I don't see what could possible go wrong and I agree it
makes the code more readable.
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-25 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 18:01 [PATCH] staging: sunxi: cedrus: centralize cedrus_open exit Ian Cowan
2022-04-25 9:20 ` Dan Carpenter
2022-04-25 9:29 ` Paul Kocialkowski [this message]
2022-04-25 10:00 ` Dan Carpenter
2022-04-26 7:39 ` Paul Kocialkowski
2022-04-28 10:26 ` Dan Carpenter
2022-04-28 11:56 ` Paul Kocialkowski
2022-04-25 9:36 ` Dan Carpenter
2022-04-25 15:52 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmZp+qgSLpT5PP2u@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=ian@linux.cowan.aero \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).