From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59F91C433F5 for ; Mon, 25 Apr 2022 21:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U2eqexg9bBLYSqJSo1CdES7nTkYZETSavXG7zdq93fw=; b=faubLixCvHtgtM /pI/JwKB7TOhy9AojIMebKJtlb0P3j9/OMBg7nPofvlL5V4Mfwcb1MuotRIBzXjhmmvVQIiuTKAur 70c+87Hf2dJFXEjEOPDRftrPgmiI8/F01WvzBt6Ilhp8odpw8H0bfFGfJU5lEh4PAtlipFpCz24Ba d6UkoaeGqNIGrSkxwPh39/FZbqK6/77e766yyMhev4ND0Kkkfi+0XBc/hzcSI8I7tK7QhCBMXROX9 g/wOZZ4hVgVaKIqrfpthQqMFl4k4MRoYTMRMsKRgqV3SsxY4/AogoxFtYo4Fu44w19B9PIxeYbSuB O96ZChl1WWDdjsYylJtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj6GA-00BUr6-1y; Mon, 25 Apr 2022 21:28:42 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj6G6-00BUoy-7O for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 21:28:40 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 22882496; Mon, 25 Apr 2022 23:28:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1650922115; bh=6Y4D8PervITwFxAlLq9FlZzsI9j5ByjzNg68Bt4nvbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=szmF1yHcQKnImWetmZTy6EiMl9MCtcjwb5W61qVnNKYbQyFk6Y2yRAggQknEIraBq OjpZGJU66aUivvDUgvFkwJ0DihIJxjIXHcJArZRGPUeUXJxosq+2IpwO1YogIRjWMD ljYLcI4LkcRJyat7FZaK0EfCVuJcxdSN/ZoVHbL8= Date: Tue, 26 Apr 2022 00:28:34 +0300 From: Laurent Pinchart To: Lucas Stach Cc: Shawn Guo , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , Paul Elder , Marek Vasut , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 01/11] soc: imx: imx8m-blk-ctrl: set power device name Message-ID: References: <20220406153402.1265474-1-l.stach@pengutronix.de> <20220406153402.1265474-2-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220406153402.1265474-2-l.stach@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_142838_453366_5AA40D11 X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lucas, Thank you for the patch. On Wed, Apr 06, 2022 at 05:33:52PM +0200, Lucas Stach wrote: > Set the name for the virtual power device to the name of the attached > blk-ctrl domain. Makes the debug output for the power domains a lot > more pleasant to read. > > Signed-off-by: Lucas Stach > --- > drivers/soc/imx/imx8m-blk-ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c > index 122f9c884b38..3071a8eca8ef 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -241,6 +241,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) > ret = PTR_ERR(domain->power_dev); > goto cleanup_pds; > } > + dev_set_name(domain->power_dev, "%s", data->name); Would it make sense to keep "genpd" in the name ? Maybe "genpd:%s" ? With or without that, Reviewed-by: Laurent Pinchart > > domain->genpd.name = data->name; > domain->genpd.power_on = imx8m_blk_ctrl_power_on; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel