From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B92FC433F5 for ; Tue, 26 Apr 2022 16:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hXdMxUd4/+bac15+aEaG6vRgd9V5if6rG9ZcuAtjQyM=; b=T1fCs+u5OtDmKM CoQIDiaf0yToVHAHWL0hnnyECGl31jqzX3ga6bA82zYDnTGqgD6cCZ/wGFrC1mpvUO2uds5XXOOpu RldSe2L3B/L6Sk6QxDwozVLxhQOHuWGhnLKmN0RRCxnO5a5bA4AG0NgblL4aKAK5nI0TRxMN7SnNs 4ri/ZAAx3s4hWUwBeRq54MEjCawIbSbjX8ZvkAtoUARqI+1JHwD4vwlNVhMTfUNnO/w5CcOkYDLP3 vinNwMuNtThIN4/rYqEWPgpzFiEMUAtiXFA62/Ds4Z7iOCjRHGRvG9sAWhhJNdqzzjXdItCCkGx9T OY7XSP6TyXgRFXBI4U9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njNil-00FHvs-UI; Tue, 26 Apr 2022 16:07:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njNib-00FHq4-0k for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 16:07:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88BB323A; Tue, 26 Apr 2022 09:07:11 -0700 (PDT) Received: from lakrids (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A4EF3F73B; Tue, 26 Apr 2022 09:07:10 -0700 (PDT) Date: Tue, 26 Apr 2022 17:07:08 +0100 From: Mark Rutland To: Alexander Popov Cc: Kees Cook , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, catalin.marinas@arm.com, luto@kernel.org, will@kernel.org Subject: Re: [PATCH 0/8] stackleak: fixes and rework Message-ID: References: <20220425115603.781311-1-mark.rutland@arm.com> <202204251551.0CFE01DF4@keescook> <91238500-61a6-1e2e-1dc2-931c0a23cca8@linux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <91238500-61a6-1e2e-1dc2-931c0a23cca8@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_090713_168603_15FBF84E X-CRM114-Status: GOOD ( 23.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 26, 2022 at 06:51:04PM +0300, Alexander Popov wrote: > On 26.04.2022 01:54, Kees Cook wrote: > > On Mon, Apr 25, 2022 at 12:55:55PM +0100, Mark Rutland wrote: > > > This series reworks the stackleak code. The first patch fixes some > > > latent issues on arm64, and the subsequent patches improve the code to > > > improve clarity and permit better code generation. > > > > This looks nice; thanks! I'll put this through build testing and get it > > applied shortly... > > > > > While the improvement is small, I think the improvement to clarity and > > > code generation is a win regardless. > > > > Agreed. I also want to manually inspect the resulting memory just to > > make sure things didn't accidentally regress. There's also an LKDTM test > > for basic functionality. > > Hi Mark and Kees! > > Glad to see this patch series. > > I've looked at it briefly. Mark, I see your questions in the patches that I > can answer. > > Please give me some time, I'm going to work on your patch series next week. > I'll return with review and testing. Sure thing, thanks! FWIW, I spotted a couple of issues in my patches today while testing, and if you're happy I can post a v2 later this week with those fixed, so you don't need to waste time with those. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel