From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E2F7C433F5 for ; Thu, 28 Apr 2022 05:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jr0BovsM6376Ijvmxx4PVJp8n9l2nfDKL4nHPfSZOC8=; b=FpwqVg2Lx3iHNM 2Ew1DVnOPfHyPqUa/TFREjQqtM8P9wFr4yil+zNjktEDae+NfxOiSo383xwLW+R/56fQE4qj0UQd+ Y2wyPMGMb2xfSlPcZ2HKtMwR8NttptgGTqjrHI0HRY+PczYyu3YtXG0NM5JSythvyVJDHHgAQHN6F feH2tPKBk75Qx78TFbbKgtTbuxeZDPNVueFhHZAcaDFcDxTIJJFUU83hIin9g9+FzclyhurWwcBuV fJGM7bunj7lGyA4YUHWtwmeso0nuk9RfsLH/OjkA3PCqmgDQ965HyAh9hkwBRMWweUy2EGNt5eoMj 0gRj0oTwyw3raHh7Mr5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njwpQ-004k7W-Lt; Thu, 28 Apr 2022 05:36:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njwpN-004k6V-Ij; Thu, 28 Apr 2022 05:36:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D2C4261CD3; Thu, 28 Apr 2022 05:36:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DEBFC385A0; Thu, 28 Apr 2022 05:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651124192; bh=W+skY9yUEL0OAM6VVty2lXt20EE+p8SAZWb/wne2n0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o9nZNRRl8vxn7YgCBDCJHGnRdTbnqpR4CB/do+AaJxDjlDC4sjXEuxslQkfYI0YOH +8IHoT9BX4tuGFHbCI0BTRacyvc0/oPRmwlHGHhzzdS8qmlyfM4mir6fpFcEPQ+3DE 8LH5Lq6C6fySHgPG+rsRPCYO4DcmpG+1vjaTXCkI= Date: Thu, 28 Apr 2022 07:36:24 +0200 From: Greg Kroah-Hartman To: Adrien Thierry Cc: Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq_arm: use standard print helpers Message-ID: References: <20220427182439.424963-1-athierry@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220427182439.424963-1-athierry@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_223633_672396_BC6E13F2 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 27, 2022 at 02:24:37PM -0400, Adrien Thierry wrote: > Replace the custom debug print macros with the standard dev_err() and > friends. > > This handles TODO item "Cleanup logging mechanism". > > Signed-off-by: Adrien Thierry > --- > .../interface/vchiq_arm/vchiq_arm.c | 158 +++--- > .../interface/vchiq_arm/vchiq_connected.c | 7 +- > .../interface/vchiq_arm/vchiq_connected.h | 4 +- > .../interface/vchiq_arm/vchiq_core.c | 495 ++++++++---------- > .../interface/vchiq_arm/vchiq_core.h | 43 +- > .../interface/vchiq_arm/vchiq_debugfs.c | 105 ---- > .../interface/vchiq_arm/vchiq_dev.c | 88 ++-- > 7 files changed, 344 insertions(+), 556 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 0596ac61e286..664940e6d9e9 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -58,10 +58,6 @@ > #define KEEPALIVE_VER 1 > #define KEEPALIVE_VER_MIN KEEPALIVE_VER > > -/* Run time control of log level, based on KERN_XXX level. */ > -int vchiq_arm_log_level = VCHIQ_LOG_DEFAULT; > -int vchiq_susp_log_level = VCHIQ_LOG_ERROR; > - > DEFINE_SPINLOCK(msg_queue_spinlock); > struct vchiq_state g_state; > > @@ -253,7 +249,7 @@ create_pagelist(char *buf, char __user *ubuf, > pagelist = dma_alloc_coherent(g_dev, pagelist_size, &dma_addr, > GFP_KERNEL); > > - vchiq_log_trace(vchiq_arm_log_level, "%s - %pK", __func__, pagelist); > + dev_dbg(g_dev, "%s - %pK", __func__, pagelist); As dev_dbg() provides the output of the function name, there's no need to keep it in here when you convert to using it. Can you fix this up and resend? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel