From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0018C433F5 for ; Thu, 28 Apr 2022 05:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NimGQpL/ZiePJTZzNUBWPQ1ZHJozUHoCr+rnn0HW8WY=; b=XunuVYveLpTzxl KrRuxW8+qlW2u12/sra6kXC2XxgLm28m/BghpcY4kYZvFHJQwnNZ6CyRLT5efTDj0pefervIAWfLU jxX6K6B43dAysX0YYM8JSg6R1sUX2RJGHHHSZLsDSmCsfDVQcTsQV6h9mLsS5jJ+PDdgw1KFHXNE2 tk49Hxm9FxiWDReovjXUano7bfU3MVQ4yowm2n7laZntNWBKcmsRXuYKasxh322sASD/yp3DeH00I mG0sN4dYIfFQkj0KuuG7e6TFL5RSKRMEZo+2FUBsSSWgNBuWs27FzKNjOt5YbifLIRL+q7CLJea2f hnkZu/6mpz8/fs9BshsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njx5Z-004nfQ-4w; Thu, 28 Apr 2022 05:53:17 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njx5W-004neW-RQ for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 05:53:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 40580B82BA4; Thu, 28 Apr 2022 05:53:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 072D4C385AD; Thu, 28 Apr 2022 05:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651125191; bh=lKtkYrn4+FEITxrNkaxTIFUj/JANxMH5XgcAihKDUWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g0GljVB0aWZgPoOHP/BiDDxothhRUBzk7FA++ZYidfpNqHrw7mDnJ2ZdjEpAndeYO GkwmtrZ6g4uUa3eHN441PadRrVUR1Vui9xCZ4Py7Mx2y70WM5XWAtMyVA//jZ6FfOs p5g8o6lOd2zLXJRoiWIzJhbhJ31enHYi3lyg0Ino= Date: Thu, 28 Apr 2022 07:53:04 +0200 From: Greg KH To: Sai Prakash Ranjan Cc: arnd@arndb.de, catalin.marinas@arm.com, rostedt@goodmis.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org, quic_psodagud@quicinc.com, quic_tsoni@quicinc.com, will@kernel.org Subject: Re: [PATCHv11 6/6] asm-generic/io: Add logging support for MMIO accessors Message-ID: References: <3de35c9f4a3a070d197bab499acefc709a6f5336.1645772606.git.quic_saipraka@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3de35c9f4a3a070d197bab499acefc709a6f5336.1645772606.git.quic_saipraka@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_225315_071872_549215FE X-CRM114-Status: GOOD ( 10.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 28, 2022 at 09:00:13AM +0530, Sai Prakash Ranjan wrote: > Add logging support for MMIO high level accessors such as read{b,w,l,q} > and their relaxed versions to aid in debugging unexpected crashes/hangs > caused by the corresponding MMIO operation. Also add a generic flag > (__DISABLE_TRACE_MMIO__) which is used to disable MMIO tracing in nVHE KVM > and if required can be used to disable MMIO tracing for specific drivers. Also, this should be split up into 2 patches, one to add the "disable the feature" flag, and one to enable it for the specific driver(s) you want. Hint, when you say "also" in a changelog text, that's a huge sign that it perhaps should be split up into smaller pieces. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel