From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93278C433EF for ; Thu, 28 Apr 2022 10:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5pHh+gP5/2Nk/4cTZ4mxRPxhZX5bixzmlBM5Zn4ixoY=; b=xFLz5dYa33D1FC Vh+Uwjqg3SDSopOYP13Zjp1wLtN8djF9EDaGg0h+cuyQMsv6m82+ymHZFOOLXGVdXRO3Eh9VOnVdb LrIv0vTZkC1PaokmOHBdTC03rbVI36NCK4e0pgn+H5wOFRYhAnmQ0V/0PK6gBBYO2TINPFJLZbYhN /HVn52QXZYhi0rD97cH1V/sVJEFNKUfZrQL7k0NshKkjs8LcFSPsX4aJhtaotmyHZyzNCaEQgD7NX nY11HpKrKZKFva9Pm4tnGpsbHOjY+MTjmEc7Kk3YSN5nOYxpbzgRd+HOlmeqyoMmO1A8udLSTRTXg tyv13RiDgGx7fKzoFABA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1jF-006GbL-7H; Thu, 28 Apr 2022 10:50:33 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1jB-006GYf-M6 for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 10:50:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 81142CE2A39; Thu, 28 Apr 2022 10:50:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 393A5C385A9; Thu, 28 Apr 2022 10:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651143022; bh=F8pll2L1NRF/wbb47dvFuHRxvVRWhslxfz73G6ce3bg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W2ra8+BGeyS3+ko4UKKDgnKQgZofYFx78EBpNdemiGmvXPNYyl6ZfvzTBiUeT3dvU 2Hd0/n6iQwQJVjdQ4DscTKQg5rVIILkxKNHpJK426fJrTY+lEHONfybX+MNDIIM50O m0O/uVKOLU8yoViJGGhwZo/aYzyqSosKSfOHbfCs= Date: Thu, 28 Apr 2022 12:50:19 +0200 From: Greg KH To: Sai Prakash Ranjan Cc: arnd@arndb.de, catalin.marinas@arm.com, rostedt@goodmis.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org, quic_psodagud@quicinc.com, quic_tsoni@quicinc.com, will@kernel.org, Bjorn Andersson Subject: Re: [PATCHv12 8/9] serial: qcom_geni_serial: Disable MMIO tracing for geni serial Message-ID: References: <3fef68a94e4947d58a199709929d30e0e2bf2e44.1651139070.git.quic_saipraka@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3fef68a94e4947d58a199709929d30e0e2bf2e44.1651139070.git.quic_saipraka@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_035029_940000_A87B5DFE X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: > Disable MMIO tracing for geni serial driver as it is a high > frequency operation for serial driver with many register reads/ > writes and not very useful to log all MMIO traces and prevent > excessive logging. > > Cc: Bjorn Andersson > Signed-off-by: Sai Prakash Ranjan > --- > drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 1543a6028856..5b48e6c2bf3c 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -1,5 +1,11 @@ > // SPDX-License-Identifier: GPL-2.0 > -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. > +/* > + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ I strongly disagree that adding a single line here warrants a copyright update. If your lawyers will sign off on this change, I am willing to reconsider. > + > +/* Disable MMIO tracing */ Please say why in the comment, not just what. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel