From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C321C433F5 for ; Thu, 28 Apr 2022 10:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oXt3yjHSAd1P14Q74U6nDb5qIabRUF5mTeCjhehA65Q=; b=G3wa3xMR3BX9SN Ni923CJdifL7QNFBhrQtzZHeguncT+OgpOQwD9dN9GbuZtuA3rOHBue/TcvuXqlQXRMA+kjJNBhPk GYQiQ3NpcDkeAiZS8UGju/R1KeaUpKCPxlJ1fg7WcOqLyrn6sg55lGnJ2j6b/3+BAZXYkGFFsanGV RFH17mjZTmytnmVH/wJXT7YZDUjMhU75IKXljowhcIBbDv8EkdlayFuLUy8CuN7QTXFXVkU4mGcwy I5CTh+VldTCtZjDHiLC0fEv7tiXzfrhBBgm5IpUEhs4f+howA1QsYN5vvNwDcueLNJRd93IGJqgmL GtyLtXT53ah2ko6t82gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1kc-006HJd-Eu; Thu, 28 Apr 2022 10:51:58 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1kZ-006HI0-A5 for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 10:51:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8CBA8B82C2E; Thu, 28 Apr 2022 10:51:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04704C385A0; Thu, 28 Apr 2022 10:51:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651143112; bh=3erY32L9hYgQLqAKAWHa/59tR5L+Qk3ytpChAIZSBnQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tuK/Y1k4Zx+cbiweMFN77l7Yt7U86pWbnwHgvtcyJakeD6ULnUIGXoLHVPBigH9ju GJlqbEATOh3Vp8fPD1s/DPXpsVUeTIEvJtSYvXghU0CRXZDsuAmiTCSzN9215zppqr 7N69IDHIMrQmwVcV2Tw5FAx5U+g4L1w3ELH6Zf+g= Date: Thu, 28 Apr 2022 12:51:49 +0200 From: Greg KH To: Sai Prakash Ranjan Cc: arnd@arndb.de, catalin.marinas@arm.com, rostedt@goodmis.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org, quic_psodagud@quicinc.com, quic_tsoni@quicinc.com, will@kernel.org Subject: Re: [PATCHv12 7/9] asm-generic/io: Add logging support for MMIO accessors Message-ID: References: <6673a2e73d3dd4c7aa01fee9b26cc4a52176ba7a.1651139070.git.quic_saipraka@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6673a2e73d3dd4c7aa01fee9b26cc4a52176ba7a.1651139070.git.quic_saipraka@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_035155_574389_A47CF1DF X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 28, 2022 at 03:25:30PM +0530, Sai Prakash Ranjan wrote: > Add logging support for MMIO high level accessors such as read{b,w,l,q} > and their relaxed versions to aid in debugging unexpected crashes/hangs > caused by the corresponding MMIO operation. > > Signed-off-by: Sai Prakash Ranjan > --- > include/asm-generic/io.h | 82 ++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 78 insertions(+), 4 deletions(-) > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > index 7ce93aaf69f8..99090722cb4b 100644 > --- a/include/asm-generic/io.h > +++ b/include/asm-generic/io.h > @@ -10,6 +10,7 @@ > #include /* I/O is all done through memory accesses */ > #include /* for memset() and memcpy() */ > #include > +#include > > #ifdef CONFIG_GENERIC_IOMAP > #include > @@ -61,6 +62,35 @@ > #define __io_par(v) __io_ar(v) > #endif > > +#if IS_ENABLED(CONFIG_TRACE_MMIO_ACCESS) && !(defined(__DISABLE_TRACE_MMIO__)) Shouldn't you document __DISABLE_TRACE_MMIO__ somewhere? It's not even in the changelog. Put a big comment above this for what is is for and how to use it. Otherwise you will forget all about this in 6 months :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel