From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Adrien Thierry <athierry@redhat.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vchiq_arm: use standard print helpers
Date: Thu, 28 Apr 2022 17:45:51 +0200 [thread overview]
Message-ID: <Ymq2rw3yn8m0t+oe@kroah.com> (raw)
In-Reply-To: <YmqxZevQJpWuLlQ3@kroah.com>
On Thu, Apr 28, 2022 at 05:23:17PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 28, 2022 at 11:05:49AM -0400, Adrien Thierry wrote:
> > Replace the custom debug print macros with the standard dev_err() and
> > friends.
> >
> > This handles TODO item "Cleanup logging mechanism".
> >
> > Signed-off-by: Adrien Thierry <athierry@redhat.com>
> > ---
> >
> > Changes since v1: removed function name in dev_dbg() calls
> >
> > .../interface/vchiq_arm/vchiq_arm.c | 157 +++---
> > .../interface/vchiq_arm/vchiq_connected.c | 7 +-
> > .../interface/vchiq_arm/vchiq_connected.h | 4 +-
> > .../interface/vchiq_arm/vchiq_core.c | 495 ++++++++----------
> > .../interface/vchiq_arm/vchiq_core.h | 43 +-
> > .../interface/vchiq_arm/vchiq_debugfs.c | 105 ----
> > .../interface/vchiq_arm/vchiq_dev.c | 86 ++-
> > 7 files changed, 341 insertions(+), 556 deletions(-)
>
> Try doing this in smaller chunks. There's a lot of churn here, and not
> all of it is correct.
>
> Try removing these one-function-at-a-time and then when it's all
> finished, you can remove the debugfs and function calls as no one is
> calling them.
That is one function you are replacing at a time, not to do this one
function you are cleaning up in the source at a time. If that makes
sense. Awkward wording...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-28 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 15:05 [PATCH v2] staging: vchiq_arm: use standard print helpers Adrien Thierry
2022-04-28 15:23 ` Greg Kroah-Hartman
2022-04-28 15:45 ` Greg Kroah-Hartman [this message]
2022-04-30 7:48 ` Stefan Wahren
2022-05-02 17:08 ` Adrien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymq2rw3yn8m0t+oe@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=athierry@redhat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox