From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7899BC433EF for ; Thu, 28 Apr 2022 12:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nbf8KWbLGPQVZwyU/ccbTmqgVkntADE/w2EI5QV5X8Y=; b=VICUJBbVNyUDAM hBWu0UYK7S8/6WnIK0tqYVp7WA5C9V9RNswcbT164qXkAh9I0TUV4dmeIm/SrQ5Ft8ObEsJNBuau9 dT+jMpLZl99n6RRWq5DaZz7E4X5TB0/86LyNUCvZLRJCNg8L9MW0IoimhY2w2MBktSz/lOlTZFDZX fIIajnQHY+jeGQChC7d3brbUjNvmyBIfM5UcDnuZ2SzHyN5RUeLpx9wByZPXqJ7HSal1rgQlXmjWD aK6hdtig1R+aV6c8j0OSHRtE0S3z+TeLY9X1uYJG1bUxvtCKX8tytxeGerNQRNF3bw3KwB8XEyEnn Yj4SoguGuZWYs/u6Iy4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk2rH-006fUZ-3P; Thu, 28 Apr 2022 12:02:56 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk2r9-006fRH-BB for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 12:02:49 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8493B82C98; Thu, 28 Apr 2022 12:02:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 005D7C385A9; Thu, 28 Apr 2022 12:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651147364; bh=RuozuLWzG4C8Ggsyl8kWlvlvUawIVpr6zx6B7prgFZM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hs17iDXfGMIN4DA5xhkGxMW2hsXvLoHy/mlZ1h2K2QQfd0VADQNRs3bkj/+QY8s1J lGiXtq7Lv7NaKJ391GPhoq5YSTaJsYdmAmrjO14yNnIIV9AdZQCuI8tmd9HdFitWgZ ak385yipdDltz09gEM2Ei+tEQCYt8gDVj4JMV/tM= Date: Thu, 28 Apr 2022 14:02:41 +0200 From: Greg KH To: Sai Prakash Ranjan Cc: arnd@arndb.de, catalin.marinas@arm.com, rostedt@goodmis.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org, quic_psodagud@quicinc.com, quic_tsoni@quicinc.com, will@kernel.org Subject: Re: [PATCHv12 7/9] asm-generic/io: Add logging support for MMIO accessors Message-ID: References: <6673a2e73d3dd4c7aa01fee9b26cc4a52176ba7a.1651139070.git.quic_saipraka@quicinc.com> <6688ffa2-ec14-9126-1296-6180bab3e1d6@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6688ffa2-ec14-9126-1296-6180bab3e1d6@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_050247_567835_6ABBEC48 X-CRM114-Status: GOOD ( 22.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 28, 2022 at 04:51:49PM +0530, Sai Prakash Ranjan wrote: > On 4/28/2022 4:21 PM, Greg KH wrote: > > On Thu, Apr 28, 2022 at 03:25:30PM +0530, Sai Prakash Ranjan wrote: > > > Add logging support for MMIO high level accessors such as read{b,w,l,q} > > > and their relaxed versions to aid in debugging unexpected crashes/hangs > > > caused by the corresponding MMIO operation. > > > > > > Signed-off-by: Sai Prakash Ranjan > > > --- > > > include/asm-generic/io.h | 82 ++++++++++++++++++++++++++++++++++++++-- > > > 1 file changed, 78 insertions(+), 4 deletions(-) > > > > > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > > > index 7ce93aaf69f8..99090722cb4b 100644 > > > --- a/include/asm-generic/io.h > > > +++ b/include/asm-generic/io.h > > > @@ -10,6 +10,7 @@ > > > #include /* I/O is all done through memory accesses */ > > > #include /* for memset() and memcpy() */ > > > #include > > > +#include > > > #ifdef CONFIG_GENERIC_IOMAP > > > #include > > > @@ -61,6 +62,35 @@ > > > #define __io_par(v) __io_ar(v) > > > #endif > > > +#if IS_ENABLED(CONFIG_TRACE_MMIO_ACCESS) && !(defined(__DISABLE_TRACE_MMIO__)) > > Shouldn't you document __DISABLE_TRACE_MMIO__ somewhere? It's not even > > in the changelog. Put a big comment above this for what is is for and > > how to use it. Otherwise you will forget all about this in 6 months :) > > > > thanks, > > > > greg k-h > > Didn't you ask me to split the patch to the one actually adding the flag and the one using it. Yes, and isn't this the commit that adds the flag? Or was that on an earlier one that I missed? Ah, it's in patch 6/9 But you should also document it here in the .h file, otherwise the only place it is described is in some random kvm Makefile that no one will ever notice :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel