Re: [PATCH 11/22] firmware: arm_scmi: Add SCMIv3.1 extended names protocols support

Florian Fainelli
2022-06-15T22:59:59Z

On 6/15/22 10:32, Cristian Marussi wrote:
>
> Ok, this was another place where a reply carrying a consistent number of
> non-segmented entries could trigger an jumbo-request to kmalloc...
>
> ..maybe this is where a transient fw issue can reply with a dramatic
> numbers of possible (non-segmented) levels (num_returned+num_remaining)
>
> (I filter out replies carrying descriptors for segmented voltage-levels
> that does not come in triplets (returned:3 remaining:0) since they are out
> of spec...but I just hit today on another fw sending such out of spec
> reply for clocks and I will relax such req probably not to break too
> many out-of-spec blobs out in the wild :P)
>
> So let me know if got new splats...

This turned out to be a nice firmware bug, someone *cough* *cough*
decided to add some extra "protection" using a temporary buffer and they
completely forgot the newly added voltage domain service, so we would
just return stale information, wonderful. This is now fixed.

Thanks a lot for your responsiveness and support.
--
Florian