[PATCH 00/22] SCMIv3.1 Miscellaneous changes

Cristian Marussi
2022-03-30T15:08:08Z

Hi all,

this series introduces a bunch of SCMIv3.1 miscellaneous changes to support
basically all the SCMIv3.1 specification [1] addition with the exclusion of
the Powercap protocol and driver which will be introduced later on in
another series.

Most notably the series adds:

- supports across all protocols for long resources naming using *_NAME_GET
dedicated new commands
- Clock protocol Rate change pre and post notifications
- Voltage protocol asynchronous voltage level set command
(VOLTAGE_LEVEL_SET_COMPLETE delayed response)
- Perf protocol power-cost in micro-watts (only internal support)
- Perf protocol PERFORMANCE_LIMITS_SET new checks

Beside this, the series starts with a few general fixes (01-08/22) and a
couple of refactoring:

- one (09/22) simply to split out of common.h into a new protocols.h all
the structures needed only by protocol code, so that the protocol
implementation can include such reduced header instead of the whole
common.h which was growing insanely

- another around the handling of multi-part commands.
SCMI already allowed to issue some commands using a multi-message scheme
through which a particularly big response, which could possibly not fit
the underlying transport max payload size, could have been split into
multiple chunks.
Such logic, though, was scattered all across various protocols, leading
to a lot of code duplication, so, before adding even more duplication
with SCMIv3.1, I split out the common logic to a couple of helpers to
handle such mechanism in a common way through some abstract iterators
(13/22) and then ported all the protocols users of such mechanism to the
common iterators (14,16-18/22).

SCMIv3.1 new features have been tested with an emulated backend server,
while refactoring has been chekced against a standard SCMI stack running
on a JUNO.

The series is based on sudeep/for-next/scmi/updates [2] on top of

commit 38a0e5b735d6 ("clk: scmi: Support atomic clock enable/disable API")

Any feedback very welcome,

Thanks,
Cristian

[1]: https://developer.arm.com/documentation/den0056/d/?lang=en
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/log/?h=for-next/scmi/updates
---

Cristian Marussi (22):
firmware: arm_scmi: Fix sorting of retrieved clock rates
firmware: arm_scmi: Make protocols init fail on basic errors
firmware: arm_scmi: Fix Base list protocols enumeration
firmware: arm_scmi: Validate BASE_DISCOVER_LIST_PROTOCOLS reply
firmware: arm_scmi: Dynamically allocate protocols array
firmware: arm_scmi: Make name_get operations return a const
firmware: arm_scmi: Check CLOCK_RATE_SET_COMPLETE async reply
firmware: arm_scmi: Remove unneeded NULL termination of clk name
firmware: arm_scmi: Split protocol specific definitions in a dedicated
header
firmware: arm_scmi: Introduce a common SCMIv3.1 .extended_name_get
helper
firmware: arm_scmi: Add SCMIv3.1 extended names protocols support
firmware: arm_scmi: Parse clock_enable_latency conditionally
firmware: arm_scmi: Add iterators for multi-part commands
firmware: arm_scmi: Use common iterators in Sensor protocol
firmware: arm_scmi: Add SCMIv3.1 SENSOR_AXIS_NAME_GET support
firmware: arm_scmi: Use common iterators in Clock protocol
firmware: arm_scmi: Use common iterators in Voltage protocol
firmware: arm_scmi: Use common iterators in Perf protocol
firmware: arm_scmi: Add SCMIv3.1 Clock notifications
firmware: arm_scmi: Add SCMIv3.1 VOLTAGE_LEVEL_SET_COMPLETE
firmware: arm_scmi: Add SCMI v3.1 Perf power-cost in microwatts
firmware: arm_scmi: Add SCMIv3.1 PERFORMANCE_LIMITS_SET checks

drivers/firmware/arm_scmi/base.c | 43 +-
drivers/firmware/arm_scmi/clock.c | 337 +++++++++++---
drivers/firmware/arm_scmi/common.h | 225 +--------
drivers/firmware/arm_scmi/driver.c | 165 ++++++-
drivers/firmware/arm_scmi/perf.c | 162 ++++---
drivers/firmware/arm_scmi/power.c | 44 +-
drivers/firmware/arm_scmi/protocols.h | 318 +++++++++++++
drivers/firmware/arm_scmi/reset.c | 40 +-
drivers/firmware/arm_scmi/sensors.c | 645 +++++++++++++++-----------
drivers/firmware/arm_scmi/system.c | 9 +-
drivers/firmware/arm_scmi/voltage.c | 218 ++++++---
include/linux/scmi_protocol.h | 31 +-
12 files changed, 1495 insertions(+), 742 deletions(-)
create mode 100644 drivers/firmware/arm_scmi/protocols.h

--
2.32.0