From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7CB3C433EF for ; Fri, 29 Apr 2022 00:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3fv8Zbe6xK9SsuOeFoSvHCxxdJO83whzoGUsAl9xoIU=; b=jlx04L6XYROYUp +TFp2PIQiv4F/l0kPz2mxIX7B0XqgeX+ZC5XNXU6wvGqITgv652gqeejxGLkeHcPNR7fSMtc1TgfF XRhE6NIWb8PdStEvC2TEo7yqdqenn0QAKD9VxdKRXS05Z8ibrgXLmrn3czQnoFftScy/SL+hl2gO8 njLEB89UFt5AoWmboEKlC/0e9E+v/4wIlwNGH7CuPbX1VDn8yyXE8hEN/bQn6GmOyuymrojN6SR/X nGPjTLuaP32wvK6Vg1GWOkKXGsp0VdGQZCfR1vNtH7Y8sSUvgeom8lEf90IatBqVXPP/0xM1y9sOg lWBZzkNCLseGiryMH+GA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkEwS-009Bg3-Mh; Fri, 29 Apr 2022 00:57:04 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkEwP-009BeN-MU; Fri, 29 Apr 2022 00:57:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=NDXFJRM7G+3xMHDd/nLJHZ8nkgsa89rne//SVuZyCYw=; b=n3yQheLliCunMagcTCQKTn1N/Q 7GFgv+RtxaFd3YXqdZqpmmiEGCJQVgu8UQoCdnCTKz3/jWNiAJTMML6sS40ZyckLIaovXw5ZqOaFh 3FuFSCziyZtxnwXhC3VsplJ7nNdEaZbIZD2yp0ILc7WsAZmvsmDjke4nckGHClTOFy9Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nkEw6-000Owc-G4; Fri, 29 Apr 2022 02:56:42 +0200 Date: Fri, 29 Apr 2022 02:56:42 +0200 From: Andrew Lunn To: Jianqun Xu Cc: kuba@kernel.org, davem@davemloft.net, joabreu@synopsys.com, alexandre.torgue@st.com, peppe.cavallaro@st.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH V2] ethernet: stmmac: support driver work for DTs without child queue node Message-ID: References: <20220428010927.526310-1-jay.xu@rock-chips.com> <20220429004605.1010751-1-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220429004605.1010751-1-jay.xu@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_175701_758750_E24D0B8A X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 29, 2022 at 08:46:05AM +0800, Jianqun Xu wrote: > The driver use the value of property 'snps,rx-queues-to-use' to loop > same numbers child nodes as queues, such as: > > gmac { > rx-queues-config { > snps,rx-queues-to-use = <1>; > queue0 { > // nothing need here. > }; > }; > }; > > Since a patch for dtc from rockchip will delete all node without any > properties or child node, the queue0 node will be deleted, that caused > the driver fail to probe: Is this the in tree dtc? Do you have a commit hash for it? That should probably be used as a Fixes: tag. Or that change to dtc needs reverting because it breaks stuff. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel