From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3FE8C433EF for ; Fri, 29 Apr 2022 01:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2K4F3Fe/B91U4nG2ZhHn3k8VzWIay47S/pJHttf+RM8=; b=HDT1em5lAPcN3p FT9fjUOmwb/sKYVTD93rjo7a2XWVlbO8NFnvE6Bs3QHMra7qIr05k95jeQ1CM69J7VTvD59aeLnw/ Ia/QS2HIjw5kOKw/H9FGoYsWN8Zlhrjpd7LizdtKb0GA+399yi0xY12Fje6Bs7SFqjzW/ZiyeWxfz ZtCg1wp92tU8Gm5lvGXO1Iqj8WE3ORS17A4hojpNppa0dR3Pjqw7uURPV8/foxndbk/ThEZ85uple wxwtJ/ljpOfB8ipQG1JYIfhCgAUkD1pK0/XTKE+t5s1nCWlhFQ41slz4bFBBfaBfh65us+xlSYSsy MGxIUbxGVDBqnGHE57+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkF7J-009Cou-U5; Fri, 29 Apr 2022 01:08:18 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkF7G-009CoL-S4 for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 01:08:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=am+pp1n2tR7U1f2aW4eLg9zcq/bG7wx/3AAqhSrs4UI=; b=U72M/kfhKhhGo/IL+Y5OjkRKA1 wkapVPbgcTecThgS/KDDY9bB+KPbjP7BSn1GStt7xJ0K/BLVAcptFzXZtJkT33YyqWsR1/ACKZGA5 bwmfrPSa5yECjrgSYsjXjenJwDslEaWPapNUCgJGYPA02GGIKEVfOaEmgHPEBmigGvps=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nkF7C-000P1c-F2; Fri, 29 Apr 2022 03:08:10 +0200 Date: Fri, 29 Apr 2022 03:08:10 +0200 From: Andrew Lunn To: Radhey Shyam Pandey Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, michal.simek@xilinx.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@xilinx.com, Shravya Kumbham Subject: Re: [PATCH 1/2] net: emaclite: Don't advertise 1000BASE-T and do auto negotiation Message-ID: References: <1651163278-12701-1-git-send-email-radhey.shyam.pandey@xilinx.com> <1651163278-12701-2-git-send-email-radhey.shyam.pandey@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1651163278-12701-2-git-send-email-radhey.shyam.pandey@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_180814_958933_6D23901C X-CRM114-Status: UNSURE ( 8.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 28, 2022 at 09:57:57PM +0530, Radhey Shyam Pandey wrote: > From: Shravya Kumbham > > In xemaclite_open() function we are setting the max speed of > emaclite to 100Mb using phy_set_max_speed() function so, > there is no need to write the advertising registers to stop > giga-bit speed and the phy_start() function starts the > auto-negotiation so, there is no need to handle it separately > using advertising registers. Remove the phy_read and phy_write > of advertising registers in xemaclite_open() function. > > Signed-off-by: Shravya Kumbham > Signed-off-by: Radhey Shyam Pandey Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel