* [PATCH] arm64: Declare non global symbols as static
@ 2022-04-29 7:55 Linu Cherian
2022-04-29 16:13 ` Marc Zyngier
2022-04-29 19:06 ` Catalin Marinas
0 siblings, 2 replies; 3+ messages in thread
From: Linu Cherian @ 2022-04-29 7:55 UTC (permalink / raw)
To: maz, catalin.marinas, will
Cc: linux-kernel, linux-arm-kernel, linuc.decode, Linu Cherian,
kernel test robot
Fix below sparse warnings introduced while adding errata.
arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
'cavium_erratum_23154_cpus' was not declared. Should it be static?
arch/arm64/kernel/cpu_errata.c:233:25: sparse: warning: symbol
'cavium_erratum_27456_cpus' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Linu Cherian <lcherian@marvell.com>
---
arch/arm64/kernel/cpu_errata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
index 4c9b5b4b7a0b..57a39cb6b489 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = {
#endif
#ifdef CONFIG_CAVIUM_ERRATUM_23154
-const struct midr_range cavium_erratum_23154_cpus[] = {
+static const struct midr_range cavium_erratum_23154_cpus[] = {
MIDR_ALL_VERSIONS(MIDR_THUNDERX),
MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX),
MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX),
@@ -230,7 +230,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = {
#endif
#ifdef CONFIG_CAVIUM_ERRATUM_27456
-const struct midr_range cavium_erratum_27456_cpus[] = {
+static const struct midr_range cavium_erratum_27456_cpus[] = {
/* Cavium ThunderX, T88 pass 1.x - 2.1 */
MIDR_RANGE(MIDR_THUNDERX, 0, 0, 1, 1),
/* Cavium ThunderX, T81 pass 1.0 */
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Declare non global symbols as static
2022-04-29 7:55 [PATCH] arm64: Declare non global symbols as static Linu Cherian
@ 2022-04-29 16:13 ` Marc Zyngier
2022-04-29 19:06 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2022-04-29 16:13 UTC (permalink / raw)
To: Linu Cherian
Cc: catalin.marinas, will, linux-kernel, linux-arm-kernel,
linuc.decode, kernel test robot
On Fri, 29 Apr 2022 08:55:35 +0100,
Linu Cherian <lcherian@marvell.com> wrote:
>
> Fix below sparse warnings introduced while adding errata.
>
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
> arch/arm64/kernel/cpu_errata.c:233:25: sparse: warning: symbol
> 'cavium_erratum_27456_cpus' was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Linu Cherian <lcherian@marvell.com>
> ---
> arch/arm64/kernel/cpu_errata.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index 4c9b5b4b7a0b..57a39cb6b489 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = {
> #endif
>
> #ifdef CONFIG_CAVIUM_ERRATUM_23154
> -const struct midr_range cavium_erratum_23154_cpus[] = {
> +static const struct midr_range cavium_erratum_23154_cpus[] = {
> MIDR_ALL_VERSIONS(MIDR_THUNDERX),
> MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX),
> MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX),
> @@ -230,7 +230,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = {
> #endif
>
> #ifdef CONFIG_CAVIUM_ERRATUM_27456
> -const struct midr_range cavium_erratum_27456_cpus[] = {
> +static const struct midr_range cavium_erratum_27456_cpus[] = {
> /* Cavium ThunderX, T88 pass 1.x - 2.1 */
> MIDR_RANGE(MIDR_THUNDERX, 0, 0, 1, 1),
> /* Cavium ThunderX, T81 pass 1.0 */
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Declare non global symbols as static
2022-04-29 7:55 [PATCH] arm64: Declare non global symbols as static Linu Cherian
2022-04-29 16:13 ` Marc Zyngier
@ 2022-04-29 19:06 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2022-04-29 19:06 UTC (permalink / raw)
To: Linu Cherian
Cc: maz, will, linux-kernel, linux-arm-kernel, linuc.decode,
kernel test robot
On Fri, Apr 29, 2022 at 01:25:35PM +0530, Linu Cherian wrote:
> Fix below sparse warnings introduced while adding errata.
>
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
> arch/arm64/kernel/cpu_errata.c:233:25: sparse: warning: symbol
> 'cavium_erratum_27456_cpus' was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Linu Cherian <lcherian@marvell.com>
> ---
> arch/arm64/kernel/cpu_errata.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index 4c9b5b4b7a0b..57a39cb6b489 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = {
> #endif
>
> #ifdef CONFIG_CAVIUM_ERRATUM_23154
> -const struct midr_range cavium_erratum_23154_cpus[] = {
> +static const struct midr_range cavium_erratum_23154_cpus[] = {
> MIDR_ALL_VERSIONS(MIDR_THUNDERX),
> MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX),
> MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX),
> @@ -230,7 +230,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = {
> #endif
>
> #ifdef CONFIG_CAVIUM_ERRATUM_27456
> -const struct midr_range cavium_erratum_27456_cpus[] = {
> +static const struct midr_range cavium_erratum_27456_cpus[] = {
> /* Cavium ThunderX, T88 pass 1.x - 2.1 */
> MIDR_RANGE(MIDR_THUNDERX, 0, 0, 1, 1),
> /* Cavium ThunderX, T81 pass 1.0 */
That's referred in arch/arm64/kernel/cpufeature.c, so the build fails.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-29 19:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-29 7:55 [PATCH] arm64: Declare non global symbols as static Linu Cherian
2022-04-29 16:13 ` Marc Zyngier
2022-04-29 19:06 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).