From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CADC6C433F5 for ; Fri, 29 Apr 2022 19:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wcTO3yOTtgGCn5WqjRBiNL0DF/BRQqNJeoT+5l+NR4Q=; b=RjjnTWmWvCbYZM ZoHJ2lTM1M49XWHMWBHaAYjVovWR8C/YBC+gG8frVn4v1stSQ2z107/6de4JeFmQJ2xBuP3XJadvo +ox91RfULYkbedz6+JAlRFWzXWQwsjiHpzzN7FyVG7Bq+9DdPRLsOu419Tnc88jyu8Ik5aGm4u5jL paCyypZKMUJl9Pm1V/58f+Pc/KsufHEW312woqJTZ+AuhGoUlmgoW0+C1S6Ood0bTZ/votU4Ahz3F Nv1AKeZ9HvMU46ZOJqzkcRZMwg92sshIKpvNZ37IPPSlXYwk+NUzLYwORaA4N5aOsrmjlGTJHfgc7 B6SoKi+wOMH+7x/E/ObQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkVwe-00CIaP-On; Fri, 29 Apr 2022 19:06:24 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkVwb-00CIa5-8u for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 19:06:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9671B83794; Fri, 29 Apr 2022 19:06:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 229CCC385A4; Fri, 29 Apr 2022 19:06:16 +0000 (UTC) Date: Fri, 29 Apr 2022 20:06:13 +0100 From: Catalin Marinas To: Linu Cherian Cc: maz@kernel.org, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuc.decode@gmail.com, kernel test robot Subject: Re: [PATCH] arm64: Declare non global symbols as static Message-ID: References: <20220429075535.10636-1-lcherian@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220429075535.10636-1-lcherian@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_120621_495807_28A9C6A0 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 29, 2022 at 01:25:35PM +0530, Linu Cherian wrote: > Fix below sparse warnings introduced while adding errata. > > arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol > 'cavium_erratum_23154_cpus' was not declared. Should it be static? > arch/arm64/kernel/cpu_errata.c:233:25: sparse: warning: symbol > 'cavium_erratum_27456_cpus' was not declared. Should it be static? > > Reported-by: kernel test robot > Signed-off-by: Linu Cherian > --- > arch/arm64/kernel/cpu_errata.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c > index 4c9b5b4b7a0b..57a39cb6b489 100644 > --- a/arch/arm64/kernel/cpu_errata.c > +++ b/arch/arm64/kernel/cpu_errata.c > @@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = { > #endif > > #ifdef CONFIG_CAVIUM_ERRATUM_23154 > -const struct midr_range cavium_erratum_23154_cpus[] = { > +static const struct midr_range cavium_erratum_23154_cpus[] = { > MIDR_ALL_VERSIONS(MIDR_THUNDERX), > MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX), > MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX), > @@ -230,7 +230,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = { > #endif > > #ifdef CONFIG_CAVIUM_ERRATUM_27456 > -const struct midr_range cavium_erratum_27456_cpus[] = { > +static const struct midr_range cavium_erratum_27456_cpus[] = { > /* Cavium ThunderX, T88 pass 1.x - 2.1 */ > MIDR_RANGE(MIDR_THUNDERX, 0, 0, 1, 1), > /* Cavium ThunderX, T81 pass 1.0 */ That's referred in arch/arm64/kernel/cpufeature.c, so the build fails. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel