From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B591C433EF for ; Fri, 13 May 2022 14:36:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mwgt9YWxOBw4KvvP3nsks+gFlYC8YbS1JLyL6tqQOXU=; b=dSqZxtev8g9zrZ ODvH/fQypGxby/hWckjowo2NuOtjyhOum28ax9F9v/uAPtPvZ2HcuWRZ/mkK4Ight8eMUUJHeRhc2 PGhCqPojrd7aEs2gJsIEES7dfrW5vr90RETQaIxlioNjUA8k98Y+GC7nCHvIYc0h2P2vGz8z9ZhAJ zGyK41ncusMewaH2cdD2wImL2fz1MZxpWv6pnxYLdW+DSUmfoX7oZPQIMDHWfDeLcXoSybep8mKTK cPSFXQMGgDlvyd5gOU1+qzLt75Po5gPh8HZtgOFChd5EbAee8mtJlmmXxURjgpx52/jFeobW3eDBT 2kbHnkYm3dAGFElrJpQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npWNp-00GSN4-Dq; Fri, 13 May 2022 14:35:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npWNl-00GSLq-L9 for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 14:35:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45E1D143D; Fri, 13 May 2022 07:35:04 -0700 (PDT) Received: from lakrids (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 717C53F5A1; Fri, 13 May 2022 07:35:03 -0700 (PDT) Date: Fri, 13 May 2022 15:35:01 +0100 From: Mark Rutland To: Mark Brown Cc: Catalin Marinas , Will Deacon , Marc Zyngier , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 08/12] arm64/sme: Automatically generate SMIDR_EL1 defines Message-ID: References: <20220510161208.631259-1-broonie@kernel.org> <20220510161208.631259-9-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220510161208.631259-9-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220513_073505_771069_0D2638D9 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 10, 2022 at 05:12:04PM +0100, Mark Brown wrote: > Automatically generate the defines for SMIDR_EL1, no functional change. > > Signed-off-by: Mark Brown > --- > arch/arm64/include/asm/sysreg.h | 1 - > arch/arm64/tools/sysreg | 9 +++++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index cbf03a1f316e..ce08a42637bc 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -463,7 +463,6 @@ > #define SYS_CCSIDR_EL1 sys_reg(3, 1, 0, 0, 0) > #define SYS_CLIDR_EL1 sys_reg(3, 1, 0, 0, 1) > #define SYS_GMID_EL1 sys_reg(3, 1, 0, 0, 4) > -#define SYS_SMIDR_EL1 sys_reg(3, 1, 0, 0, 6) > #define SYS_AIDR_EL1 sys_reg(3, 1, 0, 0, 7) > > #define SMIDR_EL1_IMPLEMENTER_SHIFT 24 > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index d0ac57648000..1bf88ca3da5b 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -197,6 +197,15 @@ Sysreg SMCR_EL1 3 0 1 2 6 > Fields SMCR_ELx > EndSysreg > > +Sysreg SMIDR_EL1 3 1 0 0 6 > +Res0 63:32 > +Field 31:24 IMPLEMENTER > +Field 23:16 REVISION > +Field 15 SMPS > +Res0 14:12 > +Field 11:0 AFFINITY > +EndSysreg These all look right to me per ARM DDI 0487H.a, section D13.2.128, pages D13-5937 to D13-5938. Reviewed-by: Mark Rutland Mark. > + > Sysreg SMCR_EL2 3 4 1 2 6 > Fields SMCR_ELx > EndSysreg > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel