From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48570C433F5 for ; Mon, 2 May 2022 19:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yVojeRkC8NigqUeslge60mUNcZ7ry4Y7xjG/nPyYozg=; b=ben4eAkBhELv/5 GwAHPT9D7M7y7Y4BqzJqmmPdiOLFQNDPU/5Yi3CWmTYpqogOJp/KL4EJp6eYfB9w05NxB189CixEs C5CAy0Wpz88HfIkdTjjVPJGxelxMfNT0opXMrX4ec3rUg/Q8wm4juDiuq2Trek4UqVYJaYcKiSjM+ 4LXO3i4uFzEgkHQQE1nSdZuPRetxross/lmcBF2UUswubJnOBkhixs5LvxbCADp37RkomFWQxJZcx Mobiws/pMUR6h9nTfQPwshsDuAS5OzybxYwbaTv/WOoU7jTvSoacP/DyZMr9BAcMEvNqi/sM1c5KY RjPningqpQbTEh26zIXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlc9z-002Rm0-FU; Mon, 02 May 2022 19:56:43 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlc9w-002RlQ-Ql for linux-arm-kernel@lists.infradead.org; Mon, 02 May 2022 19:56:42 +0000 Received: by mail-oi1-f174.google.com with SMTP id m11so16221870oib.11 for ; Mon, 02 May 2022 12:56:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/Ntv7zv1FrmWHb+PvRkaGud3vEWnl0ReBjk0xBH+pec=; b=EAhmPlZNAoNlpOrvB3I1uNJyMnNJDaiI7zCYh5dILh/7JOZY5gBIYd8iGMTSe9TI1a olOzaC4JWNlQ0zJm28VrbYwV+o8DM2yjVGMfFzFiyjy5gYJu5t4QyNdoliLJ3AP/6M3t l2SNxXGlJBOuuUSs955pdHGN86IZAMZFmveJfzcDU93nTJafWB561FYfiY4sFuXlxbtr 0c10ppEzVeuJHpqtWHAXOpV7RxF2e8lNkdOfWU2iyfy+Cl2LbDKxniwq474sMWhLH+W0 oHeT99YeuSqulNR0piMgs2UwnEDTwqkoEmV1Ey22aQcbR+/UhWC/G+SqplBZUsdl+asA KPWg== X-Gm-Message-State: AOAM531M+aN3fXtKguiSV3cRkd8ewAHNJ4xu6+fSmJVuuhYCRsZmc89a GtYKKXan2SBT7VpPlN471g== X-Google-Smtp-Source: ABdhPJw4pS6LeKZi5JhLEsijb5NRAYNdn7qYs4P7Vo1OpIrOD/8nj4swffT/m5Bedph4WORdHZEbXw== X-Received: by 2002:aca:5b45:0:b0:2fa:7d3b:6997 with SMTP id p66-20020aca5b45000000b002fa7d3b6997mr365355oib.258.1651521399580; Mon, 02 May 2022 12:56:39 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id w2-20020a056830110200b006060322127esm3205340otq.78.2022.05.02.12.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 12:56:39 -0700 (PDT) Received: (nullmailer pid 1633203 invoked by uid 1000); Mon, 02 May 2022 19:56:38 -0000 Date: Mon, 2 May 2022 14:56:38 -0500 From: Rob Herring To: Puranjay Mohan Subject: Re: [PATCH v3 1/5] dt-bindings: remoteproc: Add PRU consumer bindings Message-ID: References: <20220418104118.12878-1-p-mohan@ti.com> <20220418104118.12878-2-p-mohan@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220418104118.12878-2-p-mohan@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220502_125640_951004_30F1E345 X-CRM114-Status: GOOD ( 29.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, mathieu.poirier@linaro.org, kishon@ti.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, rogerq@kernel.org, krzysztof.kozlowski+dt@linaro.org, ssantosh@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 18, 2022 at 04:11:14PM +0530, Puranjay Mohan wrote: > From: Suman Anna > > Add a YAML binding document for PRU consumers. The binding includes > all the common properties that can be used by different PRU consumer > or application nodes and supported by the PRU remoteproc driver. > These are used to configure the PRU hardware for specific user > applications. > > The application nodes themselves should define their own bindings. > > Co-developed-by: Tero Kristo > Signed-off-by: Tero Kristo > Signed-off-by: Suman Anna > Co-developed-by: Grzegorz Jaszczyk > Signed-off-by: Grzegorz Jaszczyk > Signed-off-by: Puranjay Mohan > --- > .../bindings/remoteproc/ti,pru-consumer.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > new file mode 100644 > index 000000000000..5b1f1cb2f098 > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/ti,pru-consumer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common TI PRU Consumer Binding > + > +maintainers: > + - Suman Anna > + > +description: | > + A PRU application/consumer/user node typically uses one or more PRU device > + nodes to implement a PRU application/functionality. Each application/client > + node would need a reference to at least a PRU node, and optionally define > + some properties needed for hardware/firmware configuration. The below > + properties are a list of common properties supported by the PRU remoteproc > + infrastructure. > + > + The application nodes shall define their own bindings like regular platform > + devices, so below are in addition to each node's bindings. > + > +properties: > + ti,prus: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: phandles to the PRU, RTU or Tx_PRU nodes used > + minItems: 1 > + maxItems: 6 > + items: > + maxItems: 1 > + > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string-array > + description: | > + firmwares for the PRU cores, the default firmware for the core from > + the PRU node will be used if not provided. The firmware names should > + correspond to the PRU cores listed in the 'ti,prus' property So should be the name number of entries?: minItems: 1 maxItems: 6 > + > + ti,pruss-gp-mux-sel: > + $ref: /schemas/types.yaml#/definitions/uint32-array minItems: 1 > + maxItems: 6 > + items: > + enum: [0, 1, 2, 3, 4] > + description: | > + array of values for the GP_MUX_SEL under PRUSS_GPCFG register for a PRU. > + This selects the internal muxing scheme for the PRU instance. Values > + should correspond to the PRU cores listed in the 'ti,prus' property. The > + GP_MUX_SEL setting is a per-slice setting (one setting for PRU0, RTU0, > + and Tx_PRU0 on K3 SoCs). Use the same value for all cores within the > + same slice in the associative array. If the array size is smaller than > + the size of 'ti,prus' property, the default out-of-reset value (0) for the > + PRU core is used. > + > +required: > + - ti,prus > + > +dependencies: > + firmware-name: [ 'ti,prus' ] > + ti,pruss-gp-mux-sel: [ 'ti,prus' ] This doesn't make sense because 'ti,prus' is already required. Should all 3 properties always be required? > + > +additionalProperties: true > + > +examples: > + - | > + /* PRU application node example */ > + pru-app { > + ti,prus = <&pru0>, <&pru1>; > + firmware-name = "pruss-app-fw0", "pruss-app-fw1"; > + ti,pruss-gp-mux-sel = <2>, <1>; This example never validates, but okay I guess. > + }; > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel