From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E517C433F5 for ; Tue, 3 May 2022 07:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ogMkY05NT77DUlpxeL+YWZj4/cQBLwEhEYnA6JHPeo=; b=kP3+54pFguNFSg 5cug7Eoy6Oizn7DXdnLPMDddei4zGmRy89FcXtbckro09Zxi2dN0SwVepRwQk5Yb+JEIEijord5jY f7DlziKUCUIzhDg4yrZ135WBww/s+3l38HKwsC2hbmnrUf/u+NMFaLgOt2k90TTRMy2PgP5lDmYi9 EISA7H1uxAoSgv0TZ4XwngOdHGsF2LEKkZcWjkXjEIvGQ2bohVXStdCUQ3pZ+w1POExnYKgMBIkUQ eBi6VApS/EhxPuy/YpP44SNwlOS1oovLkKw1DnM6ufaB1V0AxNh76pUlGV9G1eAf2Ch0tIKoI5JIX g3iXdi+j26eU5sj55oMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlnKE-004RzZ-GG; Tue, 03 May 2022 07:52:02 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlmzc-004IAm-4i for linux-arm-kernel@lists.infradead.org; Tue, 03 May 2022 07:30:45 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BAA5C807E; Tue, 3 May 2022 07:27:25 +0000 (UTC) Date: Tue, 3 May 2022 10:30:40 +0300 From: Tony Lindgren To: Arnd Bergmann Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Message-ID: References: <202205031017.4TwMan3l-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220503_003044_275116_AB66AC09 X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [220503 07:18]: > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > > > From: kernel test robot > > > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > > > > > Remove unneeded variable used to store return value. > > > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > > > Reported-by: kernel test robot > > Signed-off-by: kernel test robot > > I checked the patch, and unfortunately it is wrong, the current code > needs to stay. > The problem is the SET_DMA_ERRATA() macro that accesses the > local 'errata' variable. Yeah this one keeps popping up. Maybe we can make SET_DMA_ERRATA into a function or have it at least change it to set the errata value. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel