From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E3EEC433F5 for ; Wed, 4 May 2022 15:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eE1FBEk0XptQtDKTq2ayL9+JTfdC3EC/MY5VpMVBF+4=; b=uK3zb7MaL+tx71 REEEHSn5wG1cdxn9i+ozmvS9Wv0MnVU1cbUf8tlKs1gVHypXq2qyHgvTmTk+kBwywFph31k6rkBDP yf8gyXEeDwzpV4Dq5ylDm/6hoF+RsaRFkmyis96hKweIb+yZ4nke/2TS5Vhgc/YVZ4mZVOx2vKeZD ntgU1hujjSNtldoFPWodoJoWy1BQ0KaYEhjk6EGpj3qFlB0uffzaNkhxN6br9HGPetphkOZWIn7aP 6iLdgvP7EojyM+QP7W6ZT35QWeL0rkgyyhXOTWiKo1bMN/eQQ8xy8zlQwQlz2tMwZO8Ald1dNsRC/ ahjT/1TuP41NTUWJImTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmH9Q-00BUck-13; Wed, 04 May 2022 15:42:52 +0000 Received: from mail-oa1-f46.google.com ([209.85.160.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmH9M-00BUaH-A1 for linux-arm-kernel@lists.infradead.org; Wed, 04 May 2022 15:42:49 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-ed8a3962f8so1559760fac.4 for ; Wed, 04 May 2022 08:42:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tnMRJsbiS8QiP9lDD2I4JzMT/wd9etKoP6P9ura1i48=; b=e0vdCpwmVFaHnAQ/zrNB8EjC56K3rEcKMAcaaJpP++k/7obGCJ/+eceyHFsfn+rygY fodsIxRHcbuDCkf1YtCYyCMetRnIGNO9N2+JwYIVevYWGdK6qijOx630tN3fwNmNQPCN YW04Q6Ssu1VTtz/3sF+BFZLREm7H2r9AquSDzF01fwi+9F0UZcw23XvmqmgJ/aKmJGlP JiuELyCX35rw8mh8s3EUuiIhi6acQL6XRK3zhV47DV1qEg3nLNB9TszSYbb00vx4wJkW VEuwt+c92k+bSnevzGtLb7778QjyT31rMEZp7QYnR6zE12/I5zp622mc6VuaN+2Jst9K BXkg== X-Gm-Message-State: AOAM533yb6a2WDtGwZDUP3CUzfXvWUfMzQK/4H2wTGfEjRwUERU4m4M9 ysin02WMWI7wiCrzxKVeNQ== X-Google-Smtp-Source: ABdhPJzNz108HgppQ2njmjK7spVH8oSX47FuDf8S/DyT2/BrJzu23fF4n28T9OGduSEoDRg/Cc5k1w== X-Received: by 2002:a05:6870:e412:b0:ed:a30a:2248 with SMTP id n18-20020a056870e41200b000eda30a2248mr39162oag.138.1651678964563; Wed, 04 May 2022 08:42:44 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id v4-20020a9d4e84000000b006060322124bsm5279580otk.27.2022.05.04.08.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 08:42:44 -0700 (PDT) Received: (nullmailer pid 1762666 invoked by uid 1000); Wed, 04 May 2022 15:42:40 -0000 Date: Wed, 4 May 2022 10:42:40 -0500 From: Rob Herring To: Valentin Caron Cc: Alessandro Zummo , Alexandre Belloni , Krzysztof Kozlowski , Alexandre Torgue , Gabriel Fernandez , Amelie Delaunay , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] dt-bindings: rtc: stm32: add alarm A out property to select output Message-ID: References: <20220504130233.330983-1-valentin.caron@foss.st.com> <20220504130617.331290-1-valentin.caron@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220504130617.331290-1-valentin.caron@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_084248_384784_FB1F4AEB X-CRM114-Status: GOOD ( 24.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 04, 2022 at 03:06:13PM +0200, Valentin Caron wrote: > STM32 RTC can pulse some SOC pins when an alarm of RTC expires. > > This patch adds property to activate alarm A output. The pulse can > output on three pins RTC_OUT1, RTC_OUT2, RTC_OUT2_RMP > (PC13, PB2, PI8 on stm32mp15) (PC13, PB2, PI1 on stm32mp13). > > Signed-off-by: Valentin Caron > --- > .../devicetree/bindings/rtc/st,stm32-rtc.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml > index 56d46ea35c5d..71e02604e8de 100644 > --- a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml > @@ -59,6 +59,13 @@ properties: > Refer to for the supported values. > Pinctrl state named "default" may be defined to reserve pin for RTC output. > > + st,alarm: > + $ref: "/schemas/types.yaml#/definitions/uint32" > + description: | > + To select and enable RTC Alarm A output. > + Refer to for the supported values. No, sorry, you need to define the allowed values as a schema here. > + Pinctrl state named "default" may be defined to reserve pin for RTC output. > + > allOf: > - if: > properties: > @@ -75,6 +82,9 @@ allOf: > st,lsco: > maxItems: 0 > > + st,alarm: > + maxItems: 0 st,alarm: false or: not: required: [ st,alarm ] is how you disallow a property. This should cause a warning, but this patch didn't apply for me. > + > clock-names: false > > required: > @@ -95,6 +105,9 @@ allOf: > st,lsco: > maxItems: 0 > > + st,alarm: > + maxItems: 0 > + > required: > - clock-names > - st,syscfg > @@ -117,6 +130,9 @@ allOf: > st,lsco: > maxItems: 1 > > + st,alarm: > + maxItems: 1 maxItems applies to arrays, but this is a scalar value. I don't think you need this hunk. > + > required: > - clock-names > > @@ -153,8 +169,9 @@ examples: > clocks = <&rcc RTCAPB>, <&rcc RTC>; > clock-names = "pclk", "rtc_ck"; > interrupts = ; > + st,alarm = ; > st,lsco = ; > - pinctrl-0 = <&rtc_out2_rmp_pins_a>; > + pinctrl-0 = <&rtc_out1_pins_a &rtc_out2_rmp_pins_a>; > pinctrl-names = "default"; > }; > > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel