From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E09EC433F5 for ; Thu, 5 May 2022 04:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xv8SHrOBlljdcQEOo1DpTEy0sTowwZ1tiHdzdBJTODY=; b=Vhxc2Q8gpbaSw5 m73gi2cKQI5Ukf5Sr4O+QknhZPaOvHH/TMAgwSFakK5oy3i6pyzk6hpfJeQX8zZvo3xcuUBGjz7IM ObuPbbR2JsLEZN6xzM0ZdLaKBsxX444S5MstYg5BveDE7K1wYUObX2kIRq+Vmo6d+axqErjJ8Ub/C 5TI5p9/50Tclp9gUtbYr3N2CK2PMiVhRORSMs6X/EepBGVnShh8GeFUdYXN4P3NnQZ/jbOjH5SZRS 3q2YDNDuHnqK/lfRd3eN6ORCWImi2MLAEtZwcQLasi0qoF1223CmaMarjCiirwF4YoM7tSYxqbhqN CM23vXGCp7IIzDwyxFhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmTMZ-00Dwzr-Ai; Thu, 05 May 2022 04:45:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmTMV-00DwzK-Nm for linux-arm-kernel@lists.infradead.org; Thu, 05 May 2022 04:45:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 09CD1618C5; Thu, 5 May 2022 04:45:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DA1CC385A4; Thu, 5 May 2022 04:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651725905; bh=PTaOk+WTUH819ovGW3Jcx/OVdxVUDa4lj5AEtN66c4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iZfuXtnqNPNiCo9t+O8LsLeK1k37cHkSRwwhgyMNZY8Jtu+5vkDW/hyKlRCyxuQF/ 0cPlFztUJzgQDNLRo0TVOgvZ7l/41dkOk4xpKHYp1u9GlNlmHedD1sOTlsGEBFztOt tc0Vhv9ozN2cIFGQLwiS5czYZsrQNhHDBLXoTyr2CKG8lzrzb1TUAZDWaTGTT4rJ6I JnCvEU5HlDNHmBsKmmXqTUyC5g1+b1tN4wSMLqGmmYAsiyAGDW3xsx/LrjG0Ib8HFE BJYGo3mAxEpGnj5ABXqWDNbSVrOcNe4/ujkIojIrt5lQ7Jf1tB6jp1ilozNcyv9lII 0qr9OhxJiiI2g== Date: Wed, 4 May 2022 21:45:03 -0700 From: Eric Biggers To: Nathan Huckleberry Cc: linux-crypto@vger.kernel.org, linux-fscrypt@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Paul Crowley , Sami Tolvanen , Ard Biesheuvel Subject: Re: [PATCH v6 4/9] crypto: x86/aesni-xctr: Add accelerated implementation of XCTR Message-ID: References: <20220504001823.2483834-1-nhuck@google.com> <20220504001823.2483834-5-nhuck@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220504001823.2483834-5-nhuck@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_214511_854181_763B0794 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 04, 2022 at 12:18:18AM +0000, Nathan Huckleberry wrote: > Add hardware accelerated versions of XCTR for x86-64 CPUs with AESNI > support. These implementations are modified versions of the CTR > implementations found in aesni-intel_asm.S and aes_ctrby8_avx-x86_64.S. The commit message still needs to be fixed, as I noted on v5, since there is now only one implementation being added, and aesni-intel_asm.S isn't being changed. > > More information on XCTR can be found in the HCTR2 paper: > "Length-preserving encryption with HCTR2": > https://eprint.iacr.org/2021/1441.pdf > > Signed-off-by: Nathan Huckleberry > Reviewed-by: Ard Biesheuvel > --- > arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 232 ++++++++++++++++-------- > arch/x86/crypto/aesni-intel_glue.c | 114 +++++++++++- > crypto/Kconfig | 2 +- > 3 files changed, 266 insertions(+), 82 deletions(-) Otherwise this patch looks good: Reviewed-by: Eric Biggers - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel