From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B4B7C433EF for ; Fri, 6 May 2022 01:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=40HQQKwQCYemvZMsZIlYPQw+iDVeHLxur+Laz7jJFSM=; b=rSUILy0ddgWrs4 PAkMnvJvH4hqvcB4FtoL2B6+GatWdx7Kn8w1fIssLvV/pIgEMGCLskGBjnwDBWGaiJdbX1rw6VeWe F9o+FhzbCAgo+FHrkm3vRLj0od29qM66lnO/v35BwpvDcViqgJpzAHedwIs8sUPrzcv0XxB1w6AkX fW/6m4v2iJEm+ofmpZFIr4ODlWJlqvzq6p6fdSRE+0faGnyrv1k0LAjQgSkYT7aGv0ZUVfrLyrcdx St0p3iJ8L6cRNuLwRvYDhTMM6yykrulihUpd4/vNIAeYSHlwO2Vt9F4awfQ4utwHlxYKzIiyQJwRz hhdURrny6QGq2gxen5FQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmmVD-000kT9-IC; Fri, 06 May 2022 01:11:27 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmmVA-000kSO-PE for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 01:11:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651799484; x=1683335484; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=r/8ZoH7x8kextBDC9EcGTqQBcpjNzluLvqs0Fv7Xd98=; b=XAe5sB7AV3iDAYkOGONRmEb11zWxFtzLHMnIVHzpJ+kgnv4eg+Ftehci TDoQsjqXa3McZUuU6S+9tLvV8c5KvoOCnepQFart09NddL9SH6Jy1SlIY 1UIV03Jxtp4lPfOTRGIKGshFw6xi7rinMsoQOgdUxHIyXYOfF2L8yB+9C Gb2+cl4Raykfvy2a1gYP4aNxV3f6+Q84FLLBZS2d/j0mrNAVcRpsamzlk +34OKrqokmyH9KgygmsudG2ijHtVB8o677HSPwhWuMHtzeVAZTHS/Z/I0 Odk5f84bcWzPhtFzfx4XCjApWWOknlNUNmYt+a2+06RtvXBP9sueLDRvB w==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="248844423" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="248844423" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:11:05 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="537630977" Received: from rli9-dbox.sh.intel.com (HELO rli9-dbox) ([10.239.159.142]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:11:02 -0700 Date: Fri, 6 May 2022 09:09:13 +0800 From: Philip Li To: Dave Hansen Cc: Arnd Bergmann , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Message-ID: References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_181124_872354_6F45C5BC X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > On 5/3/22 00:21, Arnd Bergmann wrote: > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > >> From: kernel test robot > >> > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > >> > >> Remove unneeded variable used to store return value. > >> > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > >> > >> Reported-by: kernel test robot > >> Signed-off-by: kernel test robot > > I checked the patch, and unfortunately it is wrong, the current code > > needs to stay. > > The problem is the SET_DMA_ERRATA() macro that accesses the > > local 'errata' variable. > > 0day folks, do we have humans looking over these before they're going > out to the list? If not, can we add some? If so, can the humans get a > little more discerning? ;) Sorry all for the bad patch. So far, we pick up several cocci warnings that we have confidence based on early result analysis and feedback, for these warnings, 0day sends out patch automatically. Thanks for the suggestion Dave, We will change current process to be more conservative and to avoid false patch by adding human analysis. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel