From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBB6BC433EF for ; Fri, 6 May 2022 07:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EPbDB166gCNueM80mZ4qM7B6fzeXS44P/1k7he/eu94=; b=KYhLxXtOKJXkAY 1BVAZBtwRMobpOUHeUnUlZR8ABJlTll4yAh90+VWu/uTqkDJQwlHPel6b04eOLKA1fd0HTP+har/z gCuKkA8/lW+3LB9JdIVOisBjVoZN++c2ManiLrp7DkeCyVqnnxZJWQs0YlePAaz46Hm44pTdOtit2 uDZ6VkEL8+TvVzgeHUIyAduaYBMN838F2fWj3cdEwws01SBhZhPu24XyejGo1QG2jiEj84TI4y1oF C4GN2d6m1euvLcG7/Vv+vELAXbtT9WcRLS9QRbCr9IaPfd+/cQgheDt8B2YmzL/a9JvdtCGZPJJdG wJhHJR87EHa9r80D59sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmsRo-001qwd-Hc; Fri, 06 May 2022 07:32:20 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmsRl-001qv1-1N for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 07:32:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651822336; x=1683358336; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SkwnacsNYIuKuqUXcnje2/FShCNjGYncVyvTKO9Qoz4=; b=nRfCRuBj/0glazi+Ka+1QAsRcrbkELVoeULk1ASx7UMQCVTM8Vc8J/PB 9OA/k+1KJIsi3F53GNbKxXuQRuMxlfdKWkZrv0o9PCNZZsBZO7L6YXO4s M/1QLg7/RHX0MD9J/eLXyrAS94nWh4kZKvi96r1Zxkzr3VPpk5L1GmY+S VPPmSBXgFRz7QG0gnLX1MciuExJA9FbQJ829fT881QTHIs1rL4NlxYrc1 Ko5Gz5p3amlR2jEfdNQhMsI8Hz+okgbpJUQuvF4RcK/Zdi4dH7KAMDgSZ yfqemFSwZFoYgpMPJmhrF8KDzImH7UeLn9B0KcbAZDXJ9JptszDexlJ+E w==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="248916206" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="248916206" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 00:31:57 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="563686566" Received: from rli9-dbox.sh.intel.com (HELO rli9-dbox) ([10.239.159.142]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 00:31:54 -0700 Date: Fri, 6 May 2022 15:30:05 +0800 From: Philip Li To: Ard Biesheuvel Cc: Dave Hansen , Arnd Bergmann , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Message-ID: References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_003217_128602_DB0004AC X-CRM114-Status: GOOD ( 25.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 06, 2022 at 09:24:26AM +0200, Ard Biesheuvel wrote: > On Fri, 6 May 2022 at 03:12, Philip Li wrote: > > > > On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > > > On 5/3/22 00:21, Arnd Bergmann wrote: > > > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > > >> From: kernel test robot > > > >> > > > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > > >> > > > >> Remove unneeded variable used to store return value. > > > >> > > > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > > > >> > > > >> Reported-by: kernel test robot > > > >> Signed-off-by: kernel test robot > > > > I checked the patch, and unfortunately it is wrong, the current code > > > > needs to stay. > > > > The problem is the SET_DMA_ERRATA() macro that accesses the > > > > local 'errata' variable. > > > > > > 0day folks, do we have humans looking over these before they're going > > > out to the list? If not, can we add some? If so, can the humans get a > > > little more discerning? ;) > > > > Sorry all for the bad patch. So far, we pick up several cocci warnings that > > we have confidence based on early result analysis and feedback, for these > > warnings, 0day sends out patch automatically. > > > > Could you please add a special header or something to such emails so I > can filter them out? I am strongly opposed to such automatic spambot > patch generation, as it wastes valuable reviewer bandwidth to save the > bot operator some time, but it think it should be the other way > around. Sorry for the trouble, we will stop sending the patch automatically and only send out patch after human confirmed/reviewed. > > We expect contributors to carefully prepare their patch submissions > before sending them to the list, and automatically generated patches > simply don't mesh with that. The fact that you use a bot does not mean > you can ignore these rules. Got it, we will improve this to follow the right way to send out patches. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel