From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E7E9C433EF for ; Fri, 6 May 2022 07:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BljKDgopsefjYmuzAZjgFzJ+1+/YChH6VWgja+yRtcQ=; b=PRL4yvwT59EylN Ph1NY8vKRBSpZmkKHhnEA4jibL/NWV+Rsrr/3m5xPkDvUcyGL0G+azm9nTie0HX3c6J8beURPtJ4I 6wym2IZMwJVt4UhRzp06XSTvnoPRp2wThFrMtXjjqGBTxRks1I3Ym97HHJqfDnycI3QDT1k3Z48Tr XNv2wyb6NgjIsCidowcrGENKJaH68ar1fvmKUXI9yvk+d6pTnfoHZZ3AwXH40/bc4QddXgQb7D51O /YP798XkMN37KXw6pABG03dwPAV/LpxESEPak9kZw80EseqMKttL1Ah7TVMOT3uqQ1Jb8TZgabAhb Yup1WxhDxUxyoEGF3mdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmsTf-001rYF-QO; Fri, 06 May 2022 07:34:15 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmsTd-001rWh-1z for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 07:34:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651822453; x=1683358453; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rpRUIxRsFJfMvDD+IjLJpjOz3re74JSzeIb7dhOzr60=; b=IznMu9RlZ6A80pCaypxnoJkJMF0nH+8rHFCVaWEJSapq45jnxl+kYa0W /gW514Mx4OZq4IZX2/WY53oFPfX2LN9sJ5Zg//KecXuu1hiMtzVjbdG9o BCergUlp04dmlpGfhN18RLOVI5jqlPrXlEJr/aS71EW7TeVmzuiINsDgZ vEVNDxt0qr/MB6hFiXM0iojQJQEw2QJ0HcJWsXxhP36hQYxjLQsPWAAIn NeYGvdzwgDEav2yIiOuvuCXKXhQvcicv7q7i65Rnrmn9FxcHYCMbs9fsS rCGCSdGSVDaA87yP/W+b+8cYYB37bDJC6x3bpjs7w2EohEfrgrT1jtRpf w==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="250377609" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="250377609" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 00:34:10 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="585831417" Received: from rli9-dbox.sh.intel.com (HELO rli9-dbox) ([10.239.159.142]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 00:34:07 -0700 Date: Fri, 6 May 2022 15:32:18 +0800 From: Philip Li To: Arnd Bergmann Cc: Dave Hansen , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Message-ID: References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_003413_209130_334E1467 X-CRM114-Status: GOOD ( 29.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 06, 2022 at 09:17:44AM +0200, Arnd Bergmann wrote: > On Fri, May 6, 2022 at 3:09 AM Philip Li wrote: > > On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > > > On 5/3/22 00:21, Arnd Bergmann wrote: > > > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > > >> From: kernel test robot > > > >> > > > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > > >> > > > >> Remove unneeded variable used to store return value. > > > >> > > > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > > > >> > > > >> Reported-by: kernel test robot > > > >> Signed-off-by: kernel test robot > > > > I checked the patch, and unfortunately it is wrong, the current code > > > > needs to stay. > > > > The problem is the SET_DMA_ERRATA() macro that accesses the > > > > local 'errata' variable. > > > > > > 0day folks, do we have humans looking over these before they're going > > > out to the list? If not, can we add some? If so, can the humans get a > > > little more discerning? ;) > > > > Sorry all for the bad patch. So far, we pick up several cocci warnings that > > we have confidence based on early result analysis and feedback, for these > > warnings, 0day sends out patch automatically. > > > > Thanks for the suggestion Dave, We will change current process to be more > > conservative and to avoid false patch by adding human analysis. > > For the returnvar.cocci false-positives, I wonder if it's possible to find them > using another coccinelle helper that detects badly formed macros which > access variables out of scope. I can't think of how this would be expressed, > but maybe someone has an idea. > > Something else went wrong in this particular patch, and I can't explain > how this happened: the subject line contains the name of the wrong platform, > "dove" rather than "omap2". My guess is that this was human error copying > the subject line from another patch, but if this came from a script, you > may want to check how this gets generated. Thanks Arnd, we will investigate this to fix our side issue. And thanks for taking time to check the detail, as mentioned in other reply, we will not send out patch unless it is carefully reviewed/acked by members of 0day. > > Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel