From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71FACC433F5 for ; Fri, 6 May 2022 08:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NToad1M79glGohCuov3EOqhPw4SaIZnYDuGm62Ot+R4=; b=WRXaKjKvlqyBIa oiPB8OTzNXiQL92TuyHK4qPh7GcuBRhY0k79eN7CWaY4RjjWy16OvJV1OaGoLhhomek69s1Sf5CEG JBNk8VeM3OhLDyNbLuVar+xid0FqsqcmjXwy8YLTkB9qec8YqJT9XOnPf/0ab5pkl2v+IYPKM6bPD 36Fr+CQDK+vSWY4ACBEFM7Vi7fczZmU0Md7BiCuEosvQSM5zURuvtqQo3VswSvz43HiCRQWwW/K/3 nGKdp4uSuyVWuEWr7MNIlE5k+Q/JQ0hVUbElYnSrOWgpAKXt0vkf/uztl9r6HD46pKJTF/ququLnd viqRVwZY6u+pNmy3O/7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmtil-002DHB-9b; Fri, 06 May 2022 08:53:55 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmtih-002DEN-GD; Fri, 06 May 2022 08:53:53 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 64CF7FB03; Fri, 6 May 2022 10:53:45 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pWt2Bo0FRgjE; Fri, 6 May 2022 10:53:44 +0200 (CEST) Date: Fri, 6 May 2022 10:53:39 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Liu Ying Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, kishon@ti.com, vkoul@kernel.org, robh@kernel.org, krzk@kernel.org, andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, robert.chiras@nxp.com, martin.kepplinger@puri.sm Subject: Re: [PATCH resend v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set() Message-ID: References: <20220419010852.452169-1-victor.liu@nxp.com> <20220419010852.452169-2-victor.liu@nxp.com> <538339829534d8ef10c68198016d198a9ec037fc.camel@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <538339829534d8ef10c68198016d198a9ec037fc.camel@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_015351_735671_445C6F9D X-CRM114-Status: GOOD ( 24.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liu, On Fri, Apr 29, 2022 at 08:30:43PM +0800, Liu Ying wrote: > Hi, > = > On Fri, 2022-04-22 at 19:24 +0200, Guido G=FCnther wrote: > > Hi, > > On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote: > > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > > > works with a Mixel MIPI DPHY + LVDS PHY combo to support either > > > a MIPI DSI display or a LVDS display. So, this patch calls > > > phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY > > > explicitly. > > > = > > > Cc: Guido G=FCnther > > > Cc: Robert Chiras > > > Cc: Martin Kepplinger > > > Cc: Andrzej Hajda > > > Cc: Neil Armstrong > > > Cc: Laurent Pinchart > > > Cc: Jonas Karlman > > > Cc: Jernej Skrabec > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: NXP Linux Team > > > Signed-off-by: Liu Ying > = > Hope this patch won't fall through the cracks. > Can someone please apply it to drm-misc-next? Robert? Applied to drm-misc-next. Cheers, -- Guido > = > Thanks, > Liu Ying > = > > > --- > > > v7->v8: > > > * Resend with Andrzej's and Jernej's mail addressed updated. > > > = > > > v6->v7: > > > * No change. > > > = > > > v5->v6: > > > * Rebase the series upon v5.17-rc1. > > > * Set PHY mode in ->mode_set() instead of ->pre_enable() in the > > > nwl-dsi > > > bridge driver due to the rebase. > > > * Drop Guido's R-b tag due to the rebase. > > > = > > > v4->v5: > > > * No change. > > > = > > > v3->v4: > > > * No change. > > > = > > > v2->v3: > > > * No change. > > > = > > > v1->v2: > > > * Add Guido's R-b tag. > > > = > > > drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > = > > > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c > > > b/drivers/gpu/drm/bridge/nwl-dsi.c > > > index d5945501a5ee..85bab7372af1 100644 > > > --- a/drivers/gpu/drm/bridge/nwl-dsi.c > > > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c > > > @@ -666,6 +666,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi > > > *dsi) > > > return ret; > > > } > > > = > > > + ret =3D phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY); > > > + if (ret < 0) { > > > + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", > > > ret); > > > + goto uninit_phy; > > > + } > > > + > > > ret =3D phy_configure(dsi->phy, phy_cfg); > > > if (ret < 0) { > > > DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", > > > ret); > > = > > I can't currently test this but it still looks good so > > = > > Reviewed-by: Guido G=FCnther > > = > > Cheers, > > -- Guido > > = > > > -- = > > > 2.25.1 > > > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel