From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2130C433F5 for ; Mon, 9 May 2022 21:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cd4j/Vx44u+dB/MWasu1zTmabAshJ9JuynYeFXYtlCI=; b=FKgOVJzAcUuTDz 2QVLpZPOL3gKYdKvc+u7G+kmSJNEaDgati3WAr/CTLQ8XCFIGMFf0iukOZjTPr5mfAe8U8lzXHt0U SD2pfSj0kqQIhc3c8psq4P1U89hpaQafw0INMhy9fF5CRh+ptVspsXEcDIu5jXOat5nepDz3diX5V wE9+PIZxJQ+oo33wCkQNzANi0bPcHH0STGNc4di8biYgzMWIy4EH/KbWaYJofGIWjQCZh+3Q3X1DZ LZdeSynfdf+26APmIfZWDG3IPBW+7KYJzyhQt//8HIf/uV0GPK+wheo07w4wJUta/cT+xeim8XWtv GZYp9HBYCiy7en7wrprw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noBAw-00GQqe-0F; Mon, 09 May 2022 21:44:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noBAt-00GQpx-9g for linux-arm-kernel@lists.infradead.org; Mon, 09 May 2022 21:44:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 970716173F; Mon, 9 May 2022 21:44:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5D69C385BA; Mon, 9 May 2022 21:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652132654; bh=OrpYST3eh9LQhsA/mepy9kiYu9eAXLw7s6pP10mWGCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o+lUDrb8wqHZOpKJE926dscuSEUWeQI0+AP5lcM9mwrBpw7gaTtxhiZPgRcYgkNcL 76cqppg/QPzuM8EkFt0VB76e+QHWu236Z8PgVzuKriRH6ZYXzBYnkyJJSfFXH5kSw3 xncL646ZEt1FAlUeUbnnD26qOK/aPq6a9Y6V86AnrQ4yNUa7jrkI6fSkMzrK0mjpAv M457SKaFA+nAqzx1BbPNHj1J12i0tr7WlRSCkqb0cJ4uSlwzbUrx1SUC2STsRpnQ1E l2DzUcwXq2NzFjcOXc/LMeRueLG1CbDHZZwuxgAbhe6XhY1l7wdDCTr2Kwun+vRI7R Hqh3gmKYGVWJQ== Date: Mon, 9 May 2022 14:44:12 -0700 From: Eric Biggers To: Nathan Huckleberry Cc: linux-crypto@vger.kernel.org, linux-fscrypt@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Paul Crowley , Sami Tolvanen , Ard Biesheuvel Subject: Re: [PATCH v7 7/9] crypto: x86/polyval: Add PCLMULQDQ accelerated implementation of POLYVAL Message-ID: References: <20220509191107.3556468-1-nhuck@google.com> <20220509191107.3556468-8-nhuck@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220509191107.3556468-8-nhuck@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_144415_412100_43AE5C23 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 09, 2022 at 07:11:05PM +0000, Nathan Huckleberry wrote: > diff --git a/arch/x86/crypto/polyval-clmulni_asm.S b/arch/x86/crypto/polyval-clmulni_asm.S [...] > +/* > + * Computes the product of two 128-bit polynomials at the memory locations > + * specified by (MSG + 16*i) and (KEY_POWERS + 16*i) and XORs the components of > + * the 256-bit product into LO, MI, HI. > + * > + * Given: > + * X = [X_1 : X_0] > + * Y = [Y_1 : Y_0] > + * > + * We compute: > + * LO += X_0 * Y_0 > + * MI += (X_0 + X_1) * (Y_0 + Y_1) > + * HI += X_1 * Y_1 The above comment (changed in v7) is describing Karatsuba multiplication, but the actual code is using schoolbook multiplication. Otherwise this looks good: Reviewed-by: Eric Biggers - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel