From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 870B6C433F5 for ; Tue, 10 May 2022 17:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5P++vkz6PYrCyIEVfo24e0d6iYEPqCud3RGPKNK4iik=; b=mqO1GuP5wvIe9X 8bLqyYE5HVV1lcNFXPIOmCWyrThecukkqEA/2zbWmHYtrBN7T/21F9NA/Bg90YjA9RpHESmBUHjAQ FXwnl4imSkZ6QLYjsSF28CI/FdW3B6IKEsKNoe80+vXJ1NMXGr6MWhlfSKnEzcEnx8wRBVFd5e0uZ MZpCTpwHm0ccg5ivhTGUOKdC9Txs3GxBZOm/FF24ZjBzhS3ZXN7fwldmg6Dovah1SDetlnDU19ICL krN6KSnmiHhBGUrLxsiSYyJYd+04c5XSo3oKT8Mpl1pkwDteHj6f1Rn8d3jt7NSCRR6PwwRJmf4gT 8gso7k7QF9t8uN5HtrPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noTNm-003IED-En; Tue, 10 May 2022 17:10:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noTNj-003ICZ-Mw for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 17:10:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD4B861811; Tue, 10 May 2022 17:10:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6860C385A6; Tue, 10 May 2022 17:10:37 +0000 (UTC) Date: Tue, 10 May 2022 18:10:34 +0100 From: Catalin Marinas To: Herbert Xu Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Linux Crypto Mailing List Subject: Re: [RFC PATCH 2/7] crypto: api - Add crypto_tfm_ctx_dma Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_101043_822833_1232AE69 X-CRM114-Status: GOOD ( 20.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Herbert, Thanks for putting this together. On Tue, May 10, 2022 at 07:07:10PM +0800, Herbert Xu wrote: > diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h > index f50c5d1725da5..cdf12e51c53a0 100644 > --- a/include/crypto/algapi.h > +++ b/include/crypto/algapi.h > @@ -189,10 +189,34 @@ static inline void crypto_xor_cpy(u8 *dst, const u8 *src1, const u8 *src2, > } > } > > +static inline void *crypto_tfm_ctx(struct crypto_tfm *tfm) > +{ > + return tfm->__crt_ctx; > +} > + > +static inline void *crypto_tfm_ctx_align(struct crypto_tfm *tfm, > + unsigned int align) > +{ > + if (align <= crypto_tfm_ctx_alignment()) > + align = 1; > + > + return PTR_ALIGN(crypto_tfm_ctx(tfm), align); > +} > + > static inline void *crypto_tfm_ctx_aligned(struct crypto_tfm *tfm) > { > - return PTR_ALIGN(crypto_tfm_ctx(tfm), > - crypto_tfm_alg_alignmask(tfm) + 1); > + return crypto_tfm_ctx_align(tfm, crypto_tfm_alg_alignmask(tfm) + 1); > +} > + > +static inline void *crypto_tfm_ctx_dma(struct crypto_tfm *tfm) > +{ > + unsigned int align = 1; > + > +#ifdef ARCH_DMA_MINALIGN > + align = ARCH_DMA_MINALIGN; > +#endif > + > + return crypto_tfm_ctx_align(tfm, align); > } Is there a case where a driver needs the minimum alignment between ARCH_DMA_MINALIGN and crypto_tfm_alg_alignmask()+1? Maybe for platforms where ARCH_DMA_MINALIGN is 8 (fully coherent) but the device's bus master alignment requirements are higher. My plan is to have ARCH_DMA_MINALIGN always defined but potentially higher than ARCH_KMALLOC_MINALIGN on specific architectures. I think crypto_tfm_ctx_dma() should use ARCH_KMALLOC_MINALIGN (and no #ifdefs) until I get my patches sorted and I'll replace it with ARCH_DMA_MINALIGN once it's defined globally (still no #ifdefs). Currently in mainline it's ARCH_KMALLOC_MINALIGN that gives the static DMA alignment. With the explicit crypto_tfm_ctx_dma(), can CRYPTO_MINALIGN_ATTR be dropped entirely? This may be beneficial in reducing the structure size when no DMA is required. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel