From: Rob Herring <robh@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, "Andy Yan" <andy.yan@rock-chips.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2
Date: Tue, 10 May 2022 12:15:29 -0500 [thread overview]
Message-ID: <YnqdsbYk+XzkVLe9@robh.at.kernel.org> (raw)
In-Reply-To: <20220510070914.2346011-2-s.hauer@pengutronix.de>
On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote:
> The VOP2 driver relies on reg-names properties, but these are not
> documented. Add the missing documentation, make reg-names mandatory
> and increase minItems to 2 as always both register spaces are needed.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> index 655d9b327f7d3..7238cdec9eb8a 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
> @@ -22,7 +22,7 @@ properties:
> - rockchip,rk3568-vop
>
> reg:
> - minItems: 1
> + minItems: 2
You ran the dt checks, right? This should give you a warning. The
correct thing is drop minItems if there's always 2 entries.
> items:
> - description:
> Must contain one entry corresponding to the base address and length
> @@ -31,6 +31,11 @@ properties:
> Can optionally contain a second entry corresponding to
> the CRTC gamma LUT address.
>
> + reg-names:
> + items:
> + - const: vop
> + - const: gamma-lut
> +
> interrupts:
> maxItems: 1
> description:
> @@ -86,6 +91,7 @@ properties:
> required:
> - compatible
> - reg
> + - reg-names
> - interrupts
> - clocks
> - clock-names
> --
> 2.30.2
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-10 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 7:09 [PATCH 0/3] RK356x VOP2: Change register space names Sascha Hauer
2022-05-10 7:09 ` [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Sascha Hauer
2022-05-10 14:08 ` Heiko Stübner
2022-05-10 17:20 ` Rob Herring
2022-05-10 17:15 ` Rob Herring [this message]
2022-05-11 8:10 ` Sascha Hauer
2022-05-10 7:09 ` [PATCH 2/3] drm: rockchip: Change register space names Sascha Hauer
2022-05-10 7:09 ` [PATCH 3/3] arm64: dts: rockchip: rk356x: Change VOP2 " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnqdsbYk+XzkVLe9@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).