From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A36FEC433EF for ; Wed, 11 May 2022 16:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZXiRcu6iHFee2ZdSECdLBLG2UAtCc8COgV3TlEkeT0U=; b=FJXQKY9Mjk/rIr ygLr+FpVdrCdWRydGRipzPTmYcfdzpeJ+GsYeHZUw6p99QJ3DZ/cqtvas/FDR59BbzmgRehwQll66 CPPSIxUyx40YFGTDFwsxSO+IrKBgWYW/xNCIXidhJ55zH+RHMExa280ZJ11DVNxvkrZtynP7cAhm0 77XdFPI8b2ELK1XOZo7iBTAd4itEUdCfbj0R1EIuUtW6EB2uRG9P5EJkvbh5fS6cG9h2syRxuVF4V EBsq4mFnUakXw0oU+uUGCBoUvJPSEHfE5KZKMozpf7QCfc+esSDCpW+2JfSfoTBXb7tIWbmngvowZ FLzZmLoG2dGNLI83rJBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nopP5-007pQp-BP; Wed, 11 May 2022 16:41:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nopP2-007pPq-42 for linux-arm-kernel@lists.infradead.org; Wed, 11 May 2022 16:41:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C4AAED1; Wed, 11 May 2022 09:41:31 -0700 (PDT) Received: from lpieralisi (unknown [10.57.1.148]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 682E63F73D; Wed, 11 May 2022 09:41:29 -0700 (PDT) Date: Wed, 11 May 2022 17:41:25 +0100 From: Lorenzo Pieralisi To: Rob Herring Cc: Luca Ceresoli , Saravana Kannan , PCI , Dan Carpenter , linux-omap , linux-arm-kernel , "linux-kernel@vger.kernel.org" , Kishon Vijay Abraham I , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Sekhar Nori Subject: Re: [PATCH 1/2] PCI: dra7xx: Fix link removal on probe error Message-ID: References: <20211214221450.589884-1-luca@lucaceresoli.net> <59a23c89-0810-eb28-acd9-7051ac34d438@lucaceresoli.net> <4579940c-27dc-733e-4022-ebea4671c839@lucaceresoli.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_094132_299322_F88236B8 X-CRM114-Status: GOOD ( 31.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 15, 2022 at 10:02:00AM -0600, Rob Herring wrote: > +Saravana > > On Tue, Jan 11, 2022 at 4:35 AM Luca Ceresoli wrote: > > > > Hi Rob, > > > > On 16/12/21 10:08, Luca Ceresoli wrote: > > > Hi Rob, > > > > > > thanks for the quick feedback! > > > > > > On 14/12/21 23:42, Rob Herring wrote: > > >> On Tue, Dec 14, 2021 at 4:15 PM Luca Ceresoli wrote: > > >>> > > >>> If a devm_phy_get() calls fails with phy_count==N (N > 0), then N links > > >>> have already been added by device_link_add() and won't be deleted by > > >>> device_link_del() because the code calls 'return' and not 'goto err_link'. > > >>> > > >>> Fix in a very simple way by doing all the devm_phy_get() calls before all > > >>> the device_link_add() calls. > > >>> > > >>> Fixes: 7a4db656a635 ("PCI: dra7xx: Create functional dependency between PCIe and PHY") > > >>> Signed-off-by: Luca Ceresoli > > >>> --- > > >>> drivers/pci/controller/dwc/pci-dra7xx.c | 2 ++ > > >>> 1 file changed, 2 insertions(+) > > >>> > > >>> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > > >>> index f7f1490e7beb..2ccc53869e13 100644 > > >>> --- a/drivers/pci/controller/dwc/pci-dra7xx.c > > >>> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > > >>> @@ -757,7 +757,9 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) > > >>> phy[i] = devm_phy_get(dev, name); > > >>> if (IS_ERR(phy[i])) > > >>> return PTR_ERR(phy[i]); > > >>> + } > > >>> > > >>> + for (i = 0; i < phy_count; i++) { > > >>> link[i] = device_link_add(dev, &phy[i]->dev, DL_FLAG_STATELESS); > > >> > > >> I think this should happen automatically now with fw_devlink being > > >> enabled by default. Can you try? > > > > > > Do you mean removal should be done automatically? I think they are not > > > due to the DL_FLAG_STATELESS flag. > > > > I would love to have feedback because, as said, I think my patch is > > correct, but if I'm wrong (which might well be) I have to drop patch 1 > > and rewrite patch 2 in a slightly more complex form. > > I mean that why do you need explicit dependency tracking here when > dependencies on a PHY should happen automatically now. IOW, what is > special about this driver and dependency? Any update on this patch ? I think patch 2 can be merged, please let me know if this one can be dropped. Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel