From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78790C433EF for ; Thu, 26 May 2022 15:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jooZRfMUK+1KG+sOevgWrMUF8+l17/rNFQV1lGHINUI=; b=L6WdsDEPujkGb4 FuqN5Khct22IZ2iSQi3pyXiP09R409GiRBKVYeJGf0QWc5IW97xrQ7++RDXN0WSRs8hs2R5pXGWiB gfdqyBlBuPW/JPW8Ok0/XkMHeYdsLkJRaskbunCfg5ZJXFEQwg7vRm+EgZXqt4p2xYJ3M0Pzc320m E+hjHTrojjAI1pNUw8ZR0vOdt2UhV1mI0Sn36UEHwfOQnNrMkOEFpI0eIzNU/0RBmUAtkvMr2EF9Q I4axJjoRulzrEYbFgNjIEp1RKLQMaIZCz2tqcdi3/LveBIPIid3F8Q293YeGdn2J3H50srcJ6J7NB wWpEqfGHC/sfjLVpjOuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuFfE-00FLSy-0n; Thu, 26 May 2022 15:44:40 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuFfC-00FLSr-8M for linux-arm-kernel@bombadil.infradead.org; Thu, 26 May 2022 15:44:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6AtZnJl7K0BPnB/u63q3lfWjROOr/hU6dMj54/yIBt8=; b=UzMeBXzTSB7RvMCU/Mq57cxHVY rTBPHAoJwy9veAnrRYHqs1oTn/yx+IfVcvSnrtvYlTDqzgZEp2U8T4wYE7oLkdEU2EOMeGeECccig VEPiN8Gl5K6tjhxfR8YaGQP7g+wRX8Itdg5PXKbEm7THMQmf01I7wPtbeat1A94R8Lr+k5OVfLKnd Jg3HXZJIHDOJ0qX4HoD+i4slcHDZcT3PEHm1udmKKA1fB4FUC2w+07CB2UB5wg38+/HEz9XKkk5HT mjAH0c0IyCkvY5XZLyu+bzDj1xZPrcX74DdWtZ1RfeG2V+WeoWH+rKSfaAV1zCdShtli8j4ZNq0Dz qxDsj8vQ==; Received: from [187.19.239.237] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuFfA-001MHO-1L for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 15:44:36 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id AADFE4036D; Thu, 26 May 2022 12:44:33 -0300 (-03) Date: Thu, 26 May 2022 12:44:33 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, german.gomez@arm.com, John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-doc@vger.kernel.org Subject: Re: [PATCH v1 4/6] perf tools: Use dynamic register set for Dwarf unwind Message-ID: References: <20220509144257.1623063-1-james.clark@arm.com> <20220509144257.1623063-5-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220509144257.1623063-5-james.clark@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, May 09, 2022 at 03:42:52PM +0100, James Clark escreveu: > Architectures can detect availability of extra registers at > runtime so use this more complete set for unwinding. This > will include the VG register on arm64 in a later commit. > > If the function isn't implemented then PERF_REGS_MASK is > returned and there is no change. Committer notes: Added util/perf_regs.c to tools/perf/util/python-ext-sources so that 'perf test python' passes, i.e. the perf python binding has all the symbols it needs, addressing: $ perf test -v python 19: 'import perf' in python : --- start --- test child forked, pid 2037817 python usage test: "echo "import sys ; sys.path.append('/tmp/build/perf/python'); import perf" | '/usr/bin/python3' " Traceback (most recent call last): File "", line 1, in ImportError: /tmp/build/perf/python/perf.cpython-310-x86_64-linux-gnu.so: undefined symbol: arch__user_reg_mask test child finished with -1 ---- end ---- 'import perf' in python: FAILED! $ > Signed-off-by: James Clark > --- > tools/perf/util/evsel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index d38722560e80..a881784da966 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -875,7 +875,7 @@ static void __evsel__config_callchain(struct evsel *evsel, struct record_opts *o > "specifying a subset with --user-regs may render DWARF unwinding unreliable, " > "so the minimal registers set (IP, SP) is explicitly forced.\n"); > } else { > - attr->sample_regs_user |= PERF_REGS_MASK; > + attr->sample_regs_user |= arch__user_reg_mask(); > } > attr->sample_stack_user = param->dump_size; > attr->exclude_callchain_user = 1; > -- > 2.28.0 -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel