From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB55AC433EF for ; Tue, 24 May 2022 17:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=STXqD4vImnBNnvYtWBBsRFHIpu2SPJ9ublh+SlTRVJU=; b=KYZY4+w0dd5lWF YGafREiB0o5TNQfcYV0HNZXXH2snJ0ZUZESPZk8zKfjyDEAc+xR6B4ZPW25cUB5i2Vghx2C7EJWrs mRpo6WkonHzkehUQAFRfPW0Wgbra+wQRbp/l89wCVYiRNg8ov/Ogifo0BP3I5mzDnW++Rl54cmnn5 NRbph1iI+nShgz80xYR4/rBPvCDWf0XSn72F5I6pYyZvDIDnF0Q/3BXX7UlGKpoEsn+UlVZeRmnSG st9QyOANhikwNWEVCU5XkBVnuEsDjNFNAOUHnMcK3SrC2YK2ZLfMZWVrcMoXFHqrOy0wSnP/HQs7Z vsW3BHh3xQ30Tip1j54Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntXwJ-008hi9-31; Tue, 24 May 2022 17:03:23 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntXwF-008hhU-71 for linux-arm-kernel@lists.infradead.org; Tue, 24 May 2022 17:03:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Lz0otVyUtFXeohL1/7oRGSZAWt7yYFABxglmdvZ5jn4=; b=r5wTJ1eLnvr5r4Aw8+N5/aiNA9 NyFwjqE4/VqIgtknbWV2et8W4ov0aoy7oC0ateRWbaJpbDSLuD451tZ+sl/x1alvcpniqdHZr/0/j hCvgpo0yvJNVnVJGowr94WDRqpOWj/1TFpCIgNhA6F7EZkVf6Cq5zzLCUUYV5OrBtV3Hc4ysvVXw+ wgUw04ucuCysx92N9fUj8Rf4OSuwGMspjsGHxB5OmMMMDs+3bQHkxUclUFFFgVSz2bBc6g5KleXwx wLo3ywMoF0A127DYjWiI9DVrBAy1P6UJrTApVOXZVInhjj7k5g1zUMwMGsscRU0duSJ8miyEz8ybi kBT4zW1w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60824) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ntXw6-0003kD-5w; Tue, 24 May 2022 18:03:10 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ntXw4-00038J-Fu; Tue, 24 May 2022 18:03:08 +0100 Date: Tue, 24 May 2022 18:03:08 +0100 From: "Russell King (Oracle)" To: Jon Hunter Cc: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, "linux-tegra@vger.kernel.org" Subject: Re: [PATCH 1/6] ARM: spectre-bhb: enable for Cortex-A15 Message-ID: References: <20220328134714.205342-1-ardb@kernel.org> <20220328134714.205342-2-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_100319_587613_73B87416 X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 24, 2022 at 03:50:17PM +0100, Jon Hunter wrote: > Hi Ard, > > On 28/03/2022 14:47, Ard Biesheuvel wrote: > > The Spectre-BHB mitigations were inadvertently left disabled for > > Cortex-A15, due to the fact that cpu_v7_bugs_init() is not called in > > that case. So fix that. > > > > Signed-off-by: Ard Biesheuvel > > --- > > arch/arm/mm/proc-v7-bugs.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/mm/proc-v7-bugs.c b/arch/arm/mm/proc-v7-bugs.c > > index 06dbfb968182..fb9f3eb6bf48 100644 > > --- a/arch/arm/mm/proc-v7-bugs.c > > +++ b/arch/arm/mm/proc-v7-bugs.c > > @@ -288,6 +288,7 @@ void cpu_v7_ca15_ibe(void) > > { > > if (check_spectre_auxcr(this_cpu_ptr(&spectre_warned), BIT(0))) > > cpu_v7_spectre_v2_init(); > > + cpu_v7_spectre_bhb_init(); > > } > > void cpu_v7_bugs_init(void) > > > Since this patch has been merged, I am seeing a ton of messages when booting > Linux on tegra124-jetson-tk1 ... > > [ 1233.327547] CPU0: Spectre BHB: using loop workaround > [ 1233.327795] CPU1: Spectre BHB: using loop workaround > [ 1233.328270] CPU1: Spectre BHB: using loop workaround Now that you mention this, I vaguely remember some email on the list a while ago about this being caused by something like cpuidle - but I'm unable to find it now. > [0] https://lore.kernel.org/linux-arm-kernel/20220519161310.1489625-1-dmitry.osipenko@collabora.com/T/ That was probably it. We can't really do this for the other print, because the system status can change as a result of CPUs being brought online. :( -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel