From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Juerg Haefliger <juerg.haefliger@canonical.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Juerg Haefliger <juergh@canonical.com>
Subject: Re: [PATCH 1/3] ARM: Kconfig: Fix indentation and add comments
Date: Tue, 17 May 2022 15:33:13 +0100 [thread overview]
Message-ID: <YoOyKb/0Mj849mt3@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220517141424.331759-2-juergh@canonical.com>
Hi,
On Tue, May 17, 2022 at 04:14:22PM +0200, Juerg Haefliger wrote:
> The convention for indentation seems to be a single tab. Help text is
> further indented by an additional two whitespaces. Fix the lines that
> violate these rules.
>
> While add it, add trailing comments to endif and endmenu statements for
> better readability.
I have never been a fan of that practice, but I understand that some
people really like it. At the end of the day, it's subjective, so
let's leave it as-is for the time being.
The other changes are worth having though. Please send a patch making
just those changes.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-17 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 14:14 [PATCH 0/3] ARM: Kconfig: Style cleanups Juerg Haefliger
2022-05-17 14:14 ` [PATCH 1/3] ARM: Kconfig: Fix indentation and add comments Juerg Haefliger
2022-05-17 14:33 ` Russell King (Oracle) [this message]
2022-05-18 6:43 ` [PATCH v2 1/3] ARM: Kconfig: Fix indentation Juerg Haefliger
2022-05-17 14:14 ` [PATCH 2/3] ARM: Kconfig-nommu: Fix indentation and quotes Juerg Haefliger
2022-05-17 14:14 ` [PATCH 3/3] ARM: Kconfig.debug: Fix indentation Juerg Haefliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoOyKb/0Mj849mt3@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=juerg.haefliger@canonical.com \
--cc=juergh@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).