From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C8B7C433EF for ; Thu, 19 May 2022 16:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oBcbY7OnBvVssGnJ5GIgKl684uWsVRtj2aXgUggkWmw=; b=4p0Dl9kApNUVSw gz3ui1N+gSng0x2OYpERGwMKBhDFeyiH+rHq79EwoF4Fbk9BSOCiCrlDpvfxk36HHD+SCMk8WJ9ce y1r/It8n3ExETlu6dYJFEgabdi1k+Ll3tA0UclM0YKb3SFu15kDsOslf1Ho4GrxWTOU4FOp5AaHE2 VPoYXKc5LRPY6lMjdh5/H87qcm7VSVilcmOusEqCQx3pUygKy+2QTFtkWllxOPXmUqBwVxVUh1Vie MT8NaXf+owx8LHWpnJPEHiViMG4x9cX00+Tzj9uoGpG56DrEOjEf4Q3DDjLJT60I+wwC1BfF4tTHK 25X3qTmzhZVtZ9bpmdJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nridY-008IAf-VX; Thu, 19 May 2022 16:04:29 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nridU-008I9I-SE for linux-arm-kernel@lists.infradead.org; Thu, 19 May 2022 16:04:26 +0000 Received: by mail-pj1-x1031.google.com with SMTP id l14so5735138pjk.2 for ; Thu, 19 May 2022 09:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zg+ynRXLZeMnK1oxqyeYVjcC5/X4aWhcXC6yBD5OT4A=; b=JqngR68puIkzlfBafI5k1wJZPvRZLdo970iM1/sHRkJapZDCKpCkU0bRTyqldOD2KA 1ZV0XBzywrjm6qyCzUUN2gge2PdeBNmhfqHpeSnuuDb/TmzoAUwZhNT/oDH5hKvHckiG CvqVPWCajw2s1CqDgtrug4r5cEza1q7Ar7kSY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zg+ynRXLZeMnK1oxqyeYVjcC5/X4aWhcXC6yBD5OT4A=; b=wCJnmHbNufvPRrSrqYgR7/eMqEI92NVaCDHTC0GGoH88bmb3MdJc6mtlBdAjJI6vpU ZIq6NjuEYSE2ig0CmTRjwkzmdAArORd2zq/SNbdL+EOD2BiTbBoY9L5HOcgHZzW0EKkz fCLw1ywMwxyaCmXA97dTRiMIbtvRgxL3aJyCQU68XGMx69HtbmeuZZilXfFV4glmvJEJ ukVlNFGEo1UbjQhgAlBgk479lzygHgy1zrzpq0bNs5NQ9bCq/LZQ4mDT5VvFFg51oZd7 uU9yDCuCkTIGB4fKEJtEX7DQkP1S2aJWe7YFuk8mLG/Upr08i6yf5V5RolhGsr9hwIMe fa7A== X-Gm-Message-State: AOAM531kS3rPipsdsOrIPCNv15geKgQiyZbevzKD3mnJzk3YQwWzRGla cnRV0W2BnowUwmFzYDpuF+y/2w== X-Google-Smtp-Source: ABdhPJy9S9/dhxwqs8xQPVr2FwoS6jmgVHh+Zr6FjGsyF9xmE8GmXAJRlr5lWzWVg8d0+Ach74RPtA== X-Received: by 2002:a17:90b:4b8a:b0:1df:75f2:d2f4 with SMTP id lr10-20020a17090b4b8a00b001df75f2d2f4mr5908520pjb.109.1652976260975; Thu, 19 May 2022 09:04:20 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:e229:79ea:227e:d9dd]) by smtp.gmail.com with UTF8SMTPSA id jx12-20020a17090b46cc00b001cd4989fec6sm5750078pjb.18.2022.05.19.09.04.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 09:04:20 -0700 (PDT) Date: Thu, 19 May 2022 09:04:19 -0700 From: Matthias Kaehlcke To: Judy Hsiao Cc: Andy Gross , Bjorn Andersson , Rob Herring , Srini Kandagatla , dianders@chromium.org, cychiang@google.com, judyhsiao@google.com, tzungbi@chromium.org, swboyd@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v1 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi Message-ID: References: <20220519084119.675990-1-judyhsiao@chromium.org> <20220519084119.675990-3-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220519084119.675990-3-judyhsiao@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220519_090424_967890_0773F9F4 X-CRM114-Status: GOOD ( 23.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 19, 2022 at 08:41:18AM +0000, Judy Hsiao wrote: > Audio dtsi for sc7280 boards that using rt5682 headset codec: > 1. Add dt nodes for sound card which use I2S playback and record > through rt5682s and I2S playback through max98357a. > 2. Enable lpass cpu node and add pin control and dai-links. > > Signed-off-by: Judy Hsiao A general note: this series depends on others like "Add lpass pin control support for audio on sc7280 based targets" [1] and "Add soundcard support for sc7280 based platforms" [2]. This should be mentioned somewhere, either in the cover letter or after '---'. [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638776 [2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638274 > --- > .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 121 ++++++++++++++++++ > 1 file changed, 121 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > new file mode 100644 > index 000000000000..9e449817f6fd > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -0,0 +1,121 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * > + * This file defines the common audio settings for the child boards using rt5682 codec. > + * > + * Copyright 2022 Google LLC. > + */ > + > +/ { > + /* BOARD-SPECIFIC TOP LEVEL NODES */ > + sound: sound { > + compatible = "google,sc7280-herobrine"; > + model = "sc7280-rt5682-max98360a-1mic"; > + > + status = "okay"; > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <0>; Is 'sound-dai-cells' really needed here? The binding doesn't mention it and the sound card isn't really a DAI. > + > + dai-link@0 { > + link-name = "MAX98360"; > + reg = <0>; Eventually the 'reg' property should be removed from the binding and DTs ([1], [2]), but for now it is needed to match the binding. [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1649863277-31615-5-git-send-email-quic_srivasam@quicinc.com/ [2] https://patchwork.kernel.org/project/linux-arm-msm/patch/1650291252-30398-5-git-send-email-quic_srivasam@quicinc.com/ > + > + cpu { > + sound-dai = <&lpass_cpu MI2S_SECONDARY>; > + }; > + > + codec { > + sound-dai = <&max98360a>; > + }; > + }; > + > + dai-link@1 { > + link-name = "ALC5682"; > + reg = <1>; > + > + cpu { > + sound-dai = <&lpass_cpu MI2S_PRIMARY>; > + }; > + > + codec { > + sound-dai = <&alc5682 0 /* aif1 */>; > + }; > + }; > + }; > +}; > + > +hp_i2c: &i2c2 { > + status = "okay"; > + clock-frequency = <400000>; > + > + alc5682: codec@1a { > + compatible = "realtek,rt5682s"; > + reg = <0x1a>; > + pinctrl-names = "default"; > + pinctrl-0 = <&hp_irq>; > + > + #sound-dai-cells = <1>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <101 IRQ_TYPE_EDGE_BOTH>; > + > + AVDD-supply = <&pp1800_alc5682>; > + MICVDD-supply = <&pp3300_codec>; The regulators are not mentioned in the binding, but the driver expects them, so I guess this is fine (maybe the binding should be updated in a separate patch?). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel