From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56BA3C433EF for ; Fri, 20 May 2022 15:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qPzO3Y5bRd0i/uALlzO/H0TAPms2XNZ5ot873wmv9HI=; b=Z0/YOU3fQ9Zz5k krOhnG70T0e5RjfAOm8NbLwL0VICbanRSP13TWHn+l+7hX2GH0jL9OvtGj+mqdhRdzrTB2Pz8ThBv i8+X7G58qkLLM6hW6covUstOiIMccw6F1U9s1x3zgbsaK6lBD9VJF26AFNkqx/D+N7TrNfypBAfyI iZeEK/QGK5jgy7YQFeNfpbeFJC0Tuu9+JkjdsqWKiRfT+rBY6gl2wTw/nmyXoUkx42arUo8xmAGWr VU+gEacd0944p8hr22dx4ecyvyXwc6B8kxjsqUR7/L57mCrHmRUvScVITkaBFfCQf8Iu++zMCZSy1 dUKFTsj78Mo+ZeZCpgJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns4cb-00DEfK-Iw; Fri, 20 May 2022 15:32:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns4cV-00DEdb-Oi for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 15:32:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2FDFB1477; Fri, 20 May 2022 08:32:50 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.7.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 482CC3F73D; Fri, 20 May 2022 08:32:49 -0700 (PDT) Date: Fri, 20 May 2022 16:32:45 +0100 From: Mark Rutland To: Mark Brown Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 9/9] arm64/sysreg: Generate definitions for FAR_ELx Message-ID: References: <20220517182219.2171814-1-broonie@kernel.org> <20220517182219.2171814-10-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220517182219.2171814-10-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_083251_899869_E3956184 X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 17, 2022 at 07:22:19PM +0100, Mark Brown wrote: > Convert FAR_ELx to automatic register generation as per DDI0487H.a. In the > architecture these registers have a single field "named" as "Faulting > Virtual Address for synchronous exceptions taken to ELx" occupying the > entire register, in order to fit in with the requirement to describe the > contents of the register I have created a single field named ADDR. FWIW, that sounds fine by me. > > No functional change. > > Signed-off-by: Mark Brown > --- > arch/arm64/include/asm/sysreg.h | 3 --- > arch/arm64/tools/sysreg | 12 ++++++++++++ > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index 09dc437030f5..8ab15c262864 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -249,7 +249,6 @@ > #define SYS_TFSR_EL1 sys_reg(3, 0, 5, 6, 0) > #define SYS_TFSRE0_EL1 sys_reg(3, 0, 5, 6, 1) > > -#define SYS_FAR_EL1 sys_reg(3, 0, 6, 0, 0) > #define SYS_PAR_EL1 sys_reg(3, 0, 7, 4, 0) > > #define SYS_PAR_EL1_F BIT(0) > @@ -560,7 +559,6 @@ > #define SYS_VSESR_EL2 sys_reg(3, 4, 5, 2, 3) > #define SYS_FPEXC32_EL2 sys_reg(3, 4, 5, 3, 0) > #define SYS_TFSR_EL2 sys_reg(3, 4, 5, 6, 0) > -#define SYS_FAR_EL2 sys_reg(3, 4, 6, 0, 0) > > #define SYS_VDISR_EL2 sys_reg(3, 4, 12, 1, 1) > #define __SYS__AP0Rx_EL2(x) sys_reg(3, 4, 12, 8, x) > @@ -615,7 +613,6 @@ > #define SYS_AFSR1_EL12 sys_reg(3, 5, 5, 1, 1) > #define SYS_ESR_EL12 sys_reg(3, 5, 5, 2, 0) > #define SYS_TFSR_EL12 sys_reg(3, 5, 5, 6, 0) > -#define SYS_FAR_EL12 sys_reg(3, 5, 6, 0, 0) > #define SYS_MAIR_EL12 sys_reg(3, 5, 10, 2, 0) > #define SYS_AMAIR_EL12 sys_reg(3, 5, 10, 3, 0) > #define SYS_VBAR_EL12 sys_reg(3, 5, 12, 0, 0) > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index 1cd1e4ea42e3..b725edc9626b 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -228,6 +228,10 @@ Sysreg SMCR_EL1 3 0 1 2 6 > Fields SMCR_ELx > EndSysreg > > +Sysreg FAR_EL1 3 0 6 0 0 > +Field 63:0 ADDR > +EndSysreg > + > SysregFields CONTEXTIDR_ELx > Res0 63:32 > Field 31:0 PROCID > @@ -351,6 +355,10 @@ Field 3:2 D1 > Field 1:0 D0 > EndSysreg > > +Sysreg FAR_EL2 3 4 6 0 0 > +Field 63:0 ADDR > +EndSysreg > + > Sysreg CONTEXTIDR_EL2 3 4 13 0 1 > Fields CONTEXTIDR_ELx > EndSysreg > @@ -367,6 +375,10 @@ Sysreg SMCR_EL12 3 5 1 2 6 > Fields SMCR_ELx > EndSysreg > > +Sysreg FAR_EL12 3 5 6 0 0 > +Field 63:0 ADDR > +EndSysreg These all look correct to me per ARM DDI 0487H.a. Reviewed-by: Mark Rutland Mark. > + > Sysreg CONTEXTIDR_EL12 3 5 13 0 1 > Fields CONTEXTIDR_ELx > EndSysreg > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel