From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5059EC433EF for ; Fri, 20 May 2022 13:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zjUVkPt8ZNI6N/CaCV0j5vCMbq/ZAzqn0y5dMtfOszM=; b=jkHKUa1OBr15Pg z25SsCpPw/EifkWPMlL93gvDg9zIyG4gz0SuiCYePRTgwyqhgMtHnvZkEsUDV1yRRAl5J+OYEkeDC tyxb0NOarJKqtpoV5c8XwrGx5rstRYUQ8rd5SOd5uByHmddxYuLqKzAWZrqT1q3Ki8z6Ls7Hif+vx Lu9c90/f/00uk2DlAKOB00eLusPg8BAAKuYUqBeFUo2XKKNhjQNzqOIeVfpQ6tcIifWeDn5z9xZfI y+tidYHCXOCi2MSVIzvKmbwhNsxidXGdmjM7p6ngkLYFL63gXXXWDhXHYrhTPGeL0G74BlYM8Q4s5 L5yCiQYc9swS+3cavdog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns2iZ-00Ce6c-Av; Fri, 20 May 2022 13:30:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns2iV-00Ce5m-On for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 13:30:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAF451477; Fri, 20 May 2022 06:30:51 -0700 (PDT) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 889D63F73D; Fri, 20 May 2022 06:30:50 -0700 (PDT) Date: Fri, 20 May 2022 14:31:03 +0100 From: Alexandru Elisei To: Vladimir Murzin Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, will@kernel.org, maz@kernel.org Subject: Re: [PATCH kvmtool] aarch64: Give up with MTE for AArch32 guest Message-ID: References: <20220520123844.127733-1-vladimir.murzin@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220520123844.127733-1-vladimir.murzin@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_063055_887389_4214A77E X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vladimir, When I run an --aarch32 guest with --debug this is the message that I'm getting: Info: (arm/aarch64/kvm.c) kvm__arch_enable_mte:146: MTE capability not available Would you mind elaborating on the merits of the message that you are proposing: Info: (arm/aarch64/kvm.c) kvm__arch_enable_mte:124: MTE is incompatible with AArch32 Is it because it explains why the capability is not available? Thanks, Alex On Fri, May 20, 2022 at 01:38:44PM +0100, Vladimir Murzin wrote: > KVM doesn't support combination of MTE and AArch32 guest, so do not > even try. > > Signed-off-by: Vladimir Murzin > --- > arm/aarch64/kvm.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arm/aarch64/kvm.c b/arm/aarch64/kvm.c > index 1b992dd..f3fe854 100644 > --- a/arm/aarch64/kvm.c > +++ b/arm/aarch64/kvm.c > @@ -120,6 +120,11 @@ void kvm__arch_enable_mte(struct kvm *kvm) > .cap = KVM_CAP_ARM_MTE, > }; > > + if (kvm->cfg.arch.aarch32_guest) { > + pr_debug("MTE is incompatible with AArch32"); > + return; > + } > + > if (kvm->cfg.arch.mte_disabled) { > pr_debug("MTE disabled by user"); > return; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel