From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 917D8C433EF for ; Fri, 20 May 2022 14:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dyRaVr+xyKlRjcPf8V8iVnEBpjc5PliM0oTzONWuv+k=; b=yt2TD/Kxvur4kO Qfzj8OiImhuMo115tdCDqUhpcK21I8F7mGzWoSQcbKdI4GeS1X8I2nNItDGTJzTdOJYCs13QCoNwi kkdvm8qFDPAalBS9Y7WjTdAtrebL5+fHChFPJqK8Dt1JSm3wT2fvPBeM8+DzFWtvd3WVXHO+XBNnW ObQkF8WMy8WulJ8Si2z3C/dfId41RkfYy5CpbBFtEor2/znfwoj/w6GkIO28IEA18/0/E96d3PeAw WlcqqsKT/5un/QE41+n+IC5u6Xlc1ZAM1N5FUhTnz/xQIKbhhvXNQ0P6M3CeSQ7Q67L9RMhi52D/7 Qz0ByAHHkgETUES2h5tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns40N-00Czw0-V4; Fri, 20 May 2022 14:53:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns40I-00CzuA-Pl for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 14:53:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AAE141477; Fri, 20 May 2022 07:53:21 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.7.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C74EC3F73D; Fri, 20 May 2022 07:53:20 -0700 (PDT) Date: Fri, 20 May 2022 15:53:13 +0100 From: Mark Rutland To: Mark Brown Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 1/9] arm64/sysreg: Generate definitions for CCSIDR2_EL1 Message-ID: References: <20220517182219.2171814-1-broonie@kernel.org> <20220517182219.2171814-2-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220517182219.2171814-2-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_075322_920589_ABE6C5F1 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 17, 2022 at 07:22:11PM +0100, Mark Brown wrote: > Convert CCSIDR2_EL1 to be automatically generated as per DDI0487H.a. No > functional change. > > Signed-off-by: Mark Brown The commit message and title say CCSIDR2_EL1, but the patch changes CCSIDR_EL1 (no '2'). > --- > arch/arm64/include/asm/sysreg.h | 1 - > arch/arm64/tools/sysreg | 8 ++++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index 91e4f8601393..45d29f34d9b3 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -456,7 +456,6 @@ > > #define SYS_CNTKCTL_EL1 sys_reg(3, 0, 14, 1, 0) > > -#define SYS_CCSIDR_EL1 sys_reg(3, 1, 0, 0, 0) > #define SYS_CLIDR_EL1 sys_reg(3, 1, 0, 0, 1) > #define SYS_GMID_EL1 sys_reg(3, 1, 0, 0, 4) > #define SYS_AIDR_EL1 sys_reg(3, 1, 0, 0, 7) > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index a236d7a821b4..db395dabc9e9 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -212,6 +212,14 @@ Sysreg SMCR_EL1 3 0 1 2 6 > Fields SMCR_ELx > EndSysreg > > +Sysreg CCSIDR_EL1 3 1 0 0 0 > +Res0 63:56 > +Field 55:32 NumSets > +Res0 31:24 > +Field 23:3 Associativity > +Field 2:0 LineSize > +EndSysreg Looking at ARM DDI 0487H.a pages D13-5299 to D13-5301, the layout of CCSIDR_EL1 depends on whether FEAT_CCIDX is implemented: * When FEAT_CCIDX is implemented: 63:56 RES0 55:32 NumSets 31:24 RES0 23:3 Associativity 2:0 LineSize * When FEAT_CCIDX is not implemented (e.g. baseline ARMv8.0) 63:32 RES0 31:28 UNKNOWN 27:13 NumSets 12:3 Associativity 2:0 LineSize The existing code doesn't depend upn the layout, so I agree there's no functional change. However, since this patch adds the FEAT_CCIDX layout specifically, I reckon we need to think about how to capture that fact in the naming. Thanks, Mark. > + > Sysreg SMIDR_EL1 3 1 0 0 6 > Res0 63:32 > Field 31:24 IMPLEMENTER > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel