From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/9] arm64/sysreg: Generate definitions for CLIDR_EL1
Date: Fri, 20 May 2022 15:56:33 +0100 [thread overview]
Message-ID: <YoesIVn7d1W+2KSF@FVFF77S0Q05N> (raw)
In-Reply-To: <20220517182219.2171814-3-broonie@kernel.org>
On Tue, May 17, 2022 at 07:22:12PM +0100, Mark Brown wrote:
> Convert CLIDR_EL1 to be automatically generated with definition as per
> DDI0487H.a. No functional change.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm64/include/asm/sysreg.h | 1 -
> arch/arm64/tools/sysreg | 16 ++++++++++++++++
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
> index 45d29f34d9b3..d7a98dc62029 100644
> --- a/arch/arm64/include/asm/sysreg.h
> +++ b/arch/arm64/include/asm/sysreg.h
> @@ -456,7 +456,6 @@
>
> #define SYS_CNTKCTL_EL1 sys_reg(3, 0, 14, 1, 0)
>
> -#define SYS_CLIDR_EL1 sys_reg(3, 1, 0, 0, 1)
> #define SYS_GMID_EL1 sys_reg(3, 1, 0, 0, 4)
> #define SYS_AIDR_EL1 sys_reg(3, 1, 0, 0, 7)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index db395dabc9e9..8b5788cbf099 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -220,6 +220,22 @@ Field 23:3 Associativity
> Field 2:0 LineSize
> EndSysreg
>
> +Sysreg CLIDR_EL1 3 1 0 0 1
> +Res0 63:47
> +Field 46:33 Ttypen
> +Field 32:30 ICB
> +Field 29:27 LoUU
> +Field 26:24 LoC
> +Field 23:21 LoUIS
> +Field 20:18 Ctype7
> +Field 17:15 Ctype6
> +Field 14:12 Ctype5
> +Field 11:9 Ctype4
> +Field 8:6 Ctype3
> +Field 5:3 Ctype2
> +Field 2:0 Ctype1
> +EndSysreg
I've compared this to ARM DDI 0487H.a, pages D13-5302 to D13-5304,
and this all looks correct to me:
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> +
> Sysreg SMIDR_EL1 3 1 0 0 6
> Res0 63:32
> Field 31:24 IMPLEMENTER
> --
> 2.30.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-20 14:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 18:22 [PATCH v1 0/9] arm64/sysreg: More system register generation Mark Brown
2022-05-17 18:22 ` [PATCH v1 1/9] arm64/sysreg: Generate definitions for CCSIDR2_EL1 Mark Brown
2022-05-20 14:53 ` Mark Rutland
2022-05-17 18:22 ` [PATCH v1 2/9] arm64/sysreg: Generate definitions for CLIDR_EL1 Mark Brown
2022-05-20 14:56 ` Mark Rutland [this message]
2022-05-17 18:22 ` [PATCH v1 3/9] arm64/sysreg: Generate definitions for CONTEXTIDR_ELx Mark Brown
2022-05-20 15:01 ` Mark Rutland
2022-05-17 18:22 ` [PATCH v1 4/9] arm64/sysreg: Generate definitions for CPACR_ELx Mark Brown
2022-05-20 15:10 ` Mark Rutland
2022-05-20 15:29 ` Mark Brown
2022-05-17 18:22 ` [PATCH v1 5/9] arm64/sysreg: Generate definitions for CSSELR_EL1 Mark Brown
2022-05-20 15:12 ` Mark Rutland
2022-05-17 18:22 ` [PATCH v1 6/9] arm64/sysreg: Generate definitions for CTR_EL0 Mark Brown
2022-05-20 15:20 ` Mark Rutland
2022-05-20 15:29 ` Mark Rutland
2022-05-17 18:22 ` [PATCH v1 7/9] arm64/sysreg: Generate definitions for DACR32_EL2 Mark Brown
2022-05-20 15:22 ` Mark Rutland
2022-05-17 18:22 ` [PATCH v1 8/9] arm64/sysreg: Generate definitions for DCZID_EL0 Mark Brown
2022-05-20 15:26 ` Mark Rutland
2022-05-17 18:22 ` [PATCH v1 9/9] arm64/sysreg: Generate definitions for FAR_ELx Mark Brown
2022-05-20 15:32 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoesIVn7d1W+2KSF@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox