From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D533CC433EF for ; Fri, 20 May 2022 14:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kT16lqbVF24olnApZLNTQRdkhrwCJFWfzHJ/tTxwfR4=; b=ROP/LUuEaoP8SE eZfo28W/+h6gvSUlmm0h1a/xaF7+MYSX+31FZSsS4k8irn3fctGxJ76GR5VpCdMW1U7A11us+GTBZ v16KyuJAArK/VOcqiNTElmQzEnaHJnecfEIzLxdWabwfhX1tRTLIXKf82cBJJs9wmtMdvXzkhExCB SyJNkT6W/qLa4Bn/Mq7qO7NGR5DjcFkAWeFjpjylw+NxqX4jfN3cGibP+xRYE1SQWDDPaP0aN7713 IzFXth5Tzln0HNUUizt01cyXg2S+PjRODcoMkqOUndO9gmR4w2bISj9/HDBzWb4rpQzHBgj14WKDj pbdcgKWi+VxK7ICmcXHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns43V-00D0qn-UD; Fri, 20 May 2022 14:56:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns43T-00D0pi-1S for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 14:56:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C6DD21477; Fri, 20 May 2022 07:56:37 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.7.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F1FD93F73D; Fri, 20 May 2022 07:56:36 -0700 (PDT) Date: Fri, 20 May 2022 15:56:33 +0100 From: Mark Rutland To: Mark Brown Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 2/9] arm64/sysreg: Generate definitions for CLIDR_EL1 Message-ID: References: <20220517182219.2171814-1-broonie@kernel.org> <20220517182219.2171814-3-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220517182219.2171814-3-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_075639_151087_10A473D9 X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 17, 2022 at 07:22:12PM +0100, Mark Brown wrote: > Convert CLIDR_EL1 to be automatically generated with definition as per > DDI0487H.a. No functional change. > > Signed-off-by: Mark Brown > --- > arch/arm64/include/asm/sysreg.h | 1 - > arch/arm64/tools/sysreg | 16 ++++++++++++++++ > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index 45d29f34d9b3..d7a98dc62029 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -456,7 +456,6 @@ > > #define SYS_CNTKCTL_EL1 sys_reg(3, 0, 14, 1, 0) > > -#define SYS_CLIDR_EL1 sys_reg(3, 1, 0, 0, 1) > #define SYS_GMID_EL1 sys_reg(3, 1, 0, 0, 4) > #define SYS_AIDR_EL1 sys_reg(3, 1, 0, 0, 7) > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index db395dabc9e9..8b5788cbf099 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -220,6 +220,22 @@ Field 23:3 Associativity > Field 2:0 LineSize > EndSysreg > > +Sysreg CLIDR_EL1 3 1 0 0 1 > +Res0 63:47 > +Field 46:33 Ttypen > +Field 32:30 ICB > +Field 29:27 LoUU > +Field 26:24 LoC > +Field 23:21 LoUIS > +Field 20:18 Ctype7 > +Field 17:15 Ctype6 > +Field 14:12 Ctype5 > +Field 11:9 Ctype4 > +Field 8:6 Ctype3 > +Field 5:3 Ctype2 > +Field 2:0 Ctype1 > +EndSysreg I've compared this to ARM DDI 0487H.a, pages D13-5302 to D13-5304, and this all looks correct to me: Reviewed-by: Mark Rutland Mark. > + > Sysreg SMIDR_EL1 3 1 0 0 6 > Res0 63:32 > Field 31:24 IMPLEMENTER > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel