From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D058AC433F5 for ; Fri, 20 May 2022 15:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oAMYZx/RersMF+LsbElEjus2hODtgwJP4lXiDRwbujo=; b=FRSt5YPERz1/Ag +rJ68sohQFYXfJJ4KsMptrxvcqQ2up1aM8jxYl+AaARl7ncSs24KgifmWwFwfgYEvP0h65IO1wJZR VxpV43LmQtOsJNWM1ecZLxNP/exSkrfGKYy2zK13Ub2Xr8/XugV+Xg+wfYsGIy0c37yVW6JA7tHBR wC4OxcXNXlz5NpY8hiP8G2f/isnkljvF0nXCO0JLSkOrsrAQxWWoMHO6Sl4qp74O2Jr99rtLVfxkc CNG3WXdbzZPY8HhKT0KCW5DbU43uE+wLN5rtAQeNfuviNvdhL43wkP87dAmY4exnBPIwwVIK92YCp /9oA2H0YA5W7FpkNM7PA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns4Gm-00D5VV-KV; Fri, 20 May 2022 15:10:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns4Gj-00D5UV-JQ for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 15:10:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73F5B1477; Fri, 20 May 2022 08:10:20 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.7.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F1E33F73D; Fri, 20 May 2022 08:10:19 -0700 (PDT) Date: Fri, 20 May 2022 16:10:15 +0100 From: Mark Rutland To: Mark Brown Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 4/9] arm64/sysreg: Generate definitions for CPACR_ELx Message-ID: References: <20220517182219.2171814-1-broonie@kernel.org> <20220517182219.2171814-5-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220517182219.2171814-5-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_081021_726158_DD023637 X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 17, 2022 at 07:22:14PM +0100, Mark Brown wrote: > Convert the CPACR system register definitions to be automatically generated > using the definitions in DDI0487H.a. The kernel does have some additional > definitions for subfields of SMEN, FPEN and ZEN which are not identified as > distinct subfields in the architecture so the definitions are not updated > as part of this patch. Maybe we should covert those over to an enumeration style? > > No functional change. > > Signed-off-by: Mark Brown > --- > arch/arm64/include/asm/sysreg.h | 2 -- > arch/arm64/tools/sysreg | 16 ++++++++++++++++ > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index 5a5d6bdaa806..c30f5aafde34 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -209,7 +209,6 @@ > #define SYS_ID_AA64MMFR2_EL1 sys_reg(3, 0, 0, 7, 2) > > #define SYS_ACTLR_EL1 sys_reg(3, 0, 1, 0, 1) > -#define SYS_CPACR_EL1 sys_reg(3, 0, 1, 0, 2) > #define SYS_RGSR_EL1 sys_reg(3, 0, 1, 0, 5) > #define SYS_GCR_EL1 sys_reg(3, 0, 1, 0, 6) > > @@ -613,7 +612,6 @@ > > /* VHE encodings for architectural EL0/1 system registers */ > #define SYS_SCTLR_EL12 sys_reg(3, 5, 1, 0, 0) > -#define SYS_CPACR_EL12 sys_reg(3, 5, 1, 0, 2) The corresponding addition to the sysreg file got caught in the prior patch (bad rebase?). > #define SYS_TTBR0_EL12 sys_reg(3, 5, 2, 0, 0) > #define SYS_TTBR1_EL12 sys_reg(3, 5, 2, 0, 1) > #define SYS_TCR_EL12 sys_reg(3, 5, 2, 0, 2) > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index e938d1117d36..21d5c140fde3 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -185,6 +185,22 @@ Field 1 A > Field 0 M > EndSysreg > > +SysregFields CPACR_ELx > +Res0 63:29 > +Field 28 TTA > +Res0 27:26 > +Field 25:24 SMEN > +Res0 23:22 > +Field 21:20 FPEN > +Res0 19:18 > +Field 17:16 ZEN > +Res0 15:0 > +EndSysregFields > + > +Sysreg CPACR_EL1 3 0 1 0 2 > +Fields CPACR_ELx > +EndSysreg These all look right to me for CPACR_EL1. Thanks, Mark. > + > Sysreg SMPRI_EL1 3 0 1 2 4 > Res0 63:4 > Field 3:0 PRIORITY > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel