From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED8C0C433F5 for ; Fri, 20 May 2022 16:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ljWNvDI21yysFcXfWOtvPMxXULiM8JN7QPHX8T841Jc=; b=IjISbCTdNNajn9 uD4clI3X4CtGVr+HTxoBc4niNQXUa4AYCXOVXvQqoOSCsImeQDH1BN7riGgFxVgjYiFUBEnMIb/OG btneOAlkaFD2QU/m7DUq9+eS87rNQUOgWV+whkqkcr5aLzge5543xciKVnyae/vLlUvHfWIitXgFP sS5Ujzo3WSo5MCO/FA8ObPmnvBKSaUhQZfFYV345eLEdT0S794viN2o0rkwR20wrf30NrmDqsZx5s GIqMHVU2H7u28u0sgAeECWAfb4lOa4nAvmiZIaNR/CL7WGYFkuTW0vn5ZzVV7fYmMdqipmMHrAze1 qF6G281KG/J5/SzZw7fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns5WS-00DezE-AL; Fri, 20 May 2022 16:30:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns5WP-00Dex9-2Y for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 16:30:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 241681477; Fri, 20 May 2022 09:30:35 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.7.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 409AA3F73D; Fri, 20 May 2022 09:30:34 -0700 (PDT) Date: Fri, 20 May 2022 17:30:27 +0100 From: Mark Rutland To: Mark Brown Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/6] arm64/sysreg: Generate definitions for CPACR_ELx Message-ID: References: <20220520161639.324236-1-broonie@kernel.org> <20220520161639.324236-4-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220520161639.324236-4-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_093037_184033_FDEEDACC X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 20, 2022 at 05:16:35PM +0100, Mark Brown wrote: > Convert the CPACR system register definitions to be automatically generated > using the definitions in DDI0487H.a. The kernel does have some additional > definitions for subfields of SMEN, FPEN and ZEN which are not identified as > distinct subfields in the architecture so the definitions are not updated > as part of this patch. > > No functional change. > > Signed-off-by: Mark Brown I do think that in future we may want to define enumerated values for the FPEN/ZEN/SMEN fields, but with that aside, all the values appear to be correct, so for this as-as: Reviewed-by: Mark Rutland Mark.rutland@arm.com> Mark. > --- > arch/arm64/include/asm/sysreg.h | 2 -- > arch/arm64/tools/sysreg | 20 ++++++++++++++++++++ > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index 4fd64e6ec407..7603c3344697 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -209,7 +209,6 @@ > #define SYS_ID_AA64MMFR2_EL1 sys_reg(3, 0, 0, 7, 2) > > #define SYS_ACTLR_EL1 sys_reg(3, 0, 1, 0, 1) > -#define SYS_CPACR_EL1 sys_reg(3, 0, 1, 0, 2) > #define SYS_RGSR_EL1 sys_reg(3, 0, 1, 0, 5) > #define SYS_GCR_EL1 sys_reg(3, 0, 1, 0, 6) > > @@ -614,7 +613,6 @@ > > /* VHE encodings for architectural EL0/1 system registers */ > #define SYS_SCTLR_EL12 sys_reg(3, 5, 1, 0, 0) > -#define SYS_CPACR_EL12 sys_reg(3, 5, 1, 0, 2) > #define SYS_TTBR0_EL12 sys_reg(3, 5, 2, 0, 0) > #define SYS_TTBR1_EL12 sys_reg(3, 5, 2, 0, 1) > #define SYS_TCR_EL12 sys_reg(3, 5, 2, 0, 2) > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index b2e01e108b8e..4bf413770b65 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -185,6 +185,22 @@ Field 1 A > Field 0 M > EndSysreg > > +SysregFields CPACR_ELx > +Res0 63:29 > +Field 28 TTA > +Res0 27:26 > +Field 25:24 SMEN > +Res0 23:22 > +Field 21:20 FPEN > +Res0 19:18 > +Field 17:16 ZEN > +Res0 15:0 > +EndSysregFields > + > +Sysreg CPACR_EL1 3 0 1 0 2 > +Fields CPACR_ELx > +EndSysreg > + > Sysreg SMPRI_EL1 3 0 1 2 4 > Res0 63:4 > Field 3:0 PRIORITY > @@ -283,6 +299,10 @@ Sysreg CONTEXTIDR_EL2 3 4 13 0 1 > Fields CONTEXTIDR_ELx > EndSysreg > > +Sysreg CPACR_EL12 3 5 1 0 2 > +Fields CPACR_ELx > +EndSysreg > + > Sysreg ZCR_EL12 3 5 1 2 0 > Fields ZCR_ELx > EndSysreg > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel