From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F5BEC433EF for ; Mon, 23 May 2022 12:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WK3P3HYDqk5m6B1esh7lTgurGCw0KZxXUsoSiv0qCJc=; b=jGQyD6g5TBk8NN R7K4x/EiIiU+6YH/0krI+RQvkWOJ7FZEkWUlW7S6/dgdHKSVgwjW2lLN4Ji9Rx9snBEPozFfMWFks yADFDv+vytjMx7GsYrqusbtOQ+0Day6sCZPyzpig7TXNH2p12SWUjmNuCNyOpuAPhfp2Ex4duIT7s TbLaduXlKaq1/CsBVKoPkO9IV4x9Qle2PYcgMtHKWo9cbOOhD2MWk2q0+zAYUtMoRfPwJFB3AUeWN PFQPryM2Sk6ViQIyniUekhqpwZ/LlPrgtUCQ3f5r0lHYSSL5us6FNo6uR6h3WA5rkrkxNx0jiRHTw sLLkATjSMvoAJKUpDMjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt78K-0047IU-2U; Mon, 23 May 2022 12:26:00 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt6dK-003syS-5v for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 11:53:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD219B81057; Mon, 23 May 2022 11:53:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E9BBC385AA; Mon, 23 May 2022 11:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653306835; bh=zRFVyDMxaTcsTQxdZCirp8RdZgXfIBOcClwrybOlKXc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EVk+PSIlVPaob1w+LkxcgQAo2Z0weTeIupgGRKHcOUbDiTmEWy5TdBms65ZIyuh3b HAF+3fwzEgdHPXkIgK1ZhWm68wwPLqdB+y9j+mN945qLRbWUwWJ16r7qBe5iETG/Wy FSlvYP7BmK0snt+um2VfZMa6AI6uCSWO90/GLFFODFSSP4Ytz/Hm+16hpKhfOEq194 oQbv7i9fd2GDCEApEUWS6hGsfcKoJNtPu6O2TDvvScjVBKePJe856Ra7GXMij6TAPa G/Vzlb7Gc1pdrKDqysXqqaasDmO6sw2qIb7SZQ1uPvNmNCtOyAckoxQPHpTHPNC0zU +7a4o+xNz9nyg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1nt6dE-00031F-Pm; Mon, 23 May 2022 13:53:52 +0200 Date: Mon, 23 May 2022 13:53:52 +0200 From: Johan Hovold To: cgel.zte@gmail.com Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: Re: [PATCH] firmware: arm_scmi: Avoid leak OF node on error Message-ID: References: <20220523111116.2898-1-chi.minghao@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220523111116.2898-1-chi.minghao@zte.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_045358_427140_8506DDC3 X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 23, 2022 at 11:11:16AM +0000, cgel.zte@gmail.com wrote: > From: Minghao Chi > > The OF node should be put before returning error in smc_chan_available(), > otherwise node's refcount will be leaked. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/firmware/arm_scmi/smc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c > index 745acfdd0b3d..43018be70edc 100644 > --- a/drivers/firmware/arm_scmi/smc.c > +++ b/drivers/firmware/arm_scmi/smc.c > @@ -55,10 +55,10 @@ static irqreturn_t smc_msg_done_isr(int irq, void *data) > static bool smc_chan_available(struct device *dev, int idx) > { > struct device_node *np = of_parse_phandle(dev->of_node, "shmem", 0); > + of_node_put(np); > if (!np) > return false; > > - of_node_put(np); > return true; > } NAK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel