From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3437C43334 for ; Tue, 7 Jun 2022 21:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jFCJ8AMF8JHsjQCciVJXnNLCCazAE5K5VYiJqnRAIiA=; b=Vnxt2nt9DOKaIX qmoGR7eulZACVv4A6kAaak1ZQ9mAxx+ZWB/AJv2UcLKGqQ7JroZAz4lKjYi9XWDyLAJMsGhCiAmOA qjXFd9u/I2bE2R3EkGduedzlZ63qLyDAIvi8YctY9p3StnxZ7RB2dileEwcEs0ViFBSWy5y8zAKOB 5UzR8jaaHoEw74iYm//ODFCxr+9r54O4Xap5wkG/y2Dm4UYFbzduM2ZfFEqQyCIx/NJfnyYPI/HeN ZKi/Hf7e8T0hrXsLW9g9z58AbyXwr0oIo9Lk7pm69YBgVHCUm9evdtQF5mTTbx3UOz6A3lGNrDbrX 11athbe4QxA9JrkDgjtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nygsB-009mRn-C3; Tue, 07 Jun 2022 21:36:23 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nygs8-009mQy-CM for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 21:36:21 +0000 Received: by mail-pj1-x1035.google.com with SMTP id l20-20020a17090a409400b001dd2a9d555bso16593490pjg.0 for ; Tue, 07 Jun 2022 14:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+tlXHJz9kisGrwJfIL/WMzkc1MTPDPH2NkDRgofMQXA=; b=CAQl78ghMWdgJpqs5v1tnPv/lepLaq6E6vHOQGSNFpzq0er9j5lbI4PgArppRnxI1i OhUHFhwQFCvy16F1fowJJ0nOReoDaAayxdilL8hHuOdrtYQOZkulXHx7HI4Tqfp0C+OG Vq9dE/RfMBMoIXhW6yIroAQ9UKNnH2hPxxa8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+tlXHJz9kisGrwJfIL/WMzkc1MTPDPH2NkDRgofMQXA=; b=vMThA2kplgdABCC6PdlCT6AFXtgsk7czM4KNfW4f0WMMVtb8sP7jaqe3uWscq7/sNQ d9DFUx+KduurWgAnYlEhp/Ufy2QEH1tXAmUDgMjd/hP/81rGxLFIPAdU+pH9BO8ZecPZ XJN4rYC0TXSjdsdkw6GuDvMoT0NRGwYgRh6xy6oMnGAO7NMrkX2UIwZTNShQn39zBI1x Gj32ztVzWw5sw43Q2LA6mFFxNs88x92jygcPn7VDW0iv3/ZckAlSaFsz4j948bwKJh+q tVFHByHBpgNY4Pdv/y6+6vg4htntz4lOsB9+Vr8NuaeT/+fJscqaHRbc5O9U1exj3IIG EH2A== X-Gm-Message-State: AOAM532WzSxlm0lSpyT2p5PGwspD37DVqLOjgl4CvdjkjQ8ZPtvj/xRy tEIDmYgJ6rEey1u27Fi/JqlT4A== X-Google-Smtp-Source: ABdhPJwOhl2xigdWsk9Ip1jYWJh9CMdZiN68xBIN0cOrLS7fUs1z4TCbxFVDM92Dxke6O0smj4+FAA== X-Received: by 2002:a17:902:9b8a:b0:163:d0ad:f9e8 with SMTP id y10-20020a1709029b8a00b00163d0adf9e8mr30304386plp.79.1654637777427; Tue, 07 Jun 2022 14:36:17 -0700 (PDT) Received: from google.com ([2620:15c:202:201:b689:cc5b:e6ad:930e]) by smtp.gmail.com with ESMTPSA id q21-20020a056a00085500b0051874318772sm5823056pfk.201.2022.06.07.14.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 14:36:16 -0700 (PDT) Date: Tue, 7 Jun 2022 14:36:14 -0700 From: Brian Norris To: Nicolas Dufresne Cc: Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Hans Verkuil , Sebastian Fricke , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ezequiel Garcia , stable@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: Assign RK3399 VDU clock rate Message-ID: References: <20220607141535.1.Idafe043ffc94756a69426ec68872db0645c5d6e2@changeid> <253e2771abb13a3e62c07dfb0b420169bb572c2d.camel@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <253e2771abb13a3e62c07dfb0b420169bb572c2d.camel@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_143620_478796_548E9D1F X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 07, 2022 at 05:20:41PM -0400, Nicolas Dufresne wrote: > Reviewed-by: Nicolas Dufresne Thanks! > My only doubt was if you really needed to duplicate that setting into gru- > scarlet.dtsi, but I've simply assumed the answer is yes, and that you already > checked that. I didn't explicitly test without modifying gru-scarlet.dtsi, but the unfortunate nature of these long monolithic assigned-clocks/assigned-clock-rates properties is that if you want to add or override one element in the array, you have to repeat (or override) all of them. And because rk3399-gru-scarlet.dtsi already overrides some of them, every additional change has to be reflected there. That's why it would be much nicer to be able to distribute the assignments to their various consumer nodes, but as noted in the commit message (because you mentioned it to me out-of-band ;) ), we can't do that. Regards, Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel