From: Greg KH <gregkh@linuxfoundation.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] staging: vchiq: make vchiq_platform_init static
Date: Mon, 6 Jun 2022 07:54:44 +0200 [thread overview]
Message-ID: <Yp2WpCKVjLMe0qJO@kroah.com> (raw)
In-Reply-To: <20220525093851.59514-1-jiapeng.chong@linux.alibaba.com>
On Wed, May 25, 2022 at 05:38:51PM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of vchiq_arm.c, so marks it
> static.
>
> Fixes the following w1 warning:
What tool is "w1"?
>
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:466:5:
> warning: no previous prototype for ‘vchiq_platform_init’
> [-Wmissing-prototypes].
See my previous comments on how to do this properly.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-06 5:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 9:38 [PATCH] staging: vchiq: make vchiq_platform_init static Jiapeng Chong
2022-06-06 5:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp2WpCKVjLMe0qJO@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abaci@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).