* [PATCH] staging: vchiq: make vchiq_platform_init static
@ 2022-05-25 9:38 Jiapeng Chong
2022-06-06 5:54 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-05-25 9:38 UTC (permalink / raw)
To: nsaenz
Cc: bcm-kernel-feedback-list, gregkh, linux-rpi-kernel,
linux-arm-kernel, linux-staging, linux-kernel, Jiapeng Chong,
Abaci Robot
This symbol is not used outside of vchiq_arm.c, so marks it
static.
Fixes the following w1 warning:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:466:5:
warning: no previous prototype for ‘vchiq_platform_init’
[-Wmissing-prototypes].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 0596ac61e286..7de98655e8ec 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -463,7 +463,7 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo,
cleanup_pagelistinfo(pagelistinfo);
}
-int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
+static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
{
struct device *dev = &pdev->dev;
struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev);
--
2.20.1.7.g153144c
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: vchiq: make vchiq_platform_init static
2022-05-25 9:38 [PATCH] staging: vchiq: make vchiq_platform_init static Jiapeng Chong
@ 2022-06-06 5:54 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-06-06 5:54 UTC (permalink / raw)
To: Jiapeng Chong
Cc: nsaenz, bcm-kernel-feedback-list, linux-rpi-kernel,
linux-arm-kernel, linux-staging, linux-kernel, Abaci Robot
On Wed, May 25, 2022 at 05:38:51PM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of vchiq_arm.c, so marks it
> static.
>
> Fixes the following w1 warning:
What tool is "w1"?
>
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:466:5:
> warning: no previous prototype for ‘vchiq_platform_init’
> [-Wmissing-prototypes].
See my previous comments on how to do this properly.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-06 5:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-25 9:38 [PATCH] staging: vchiq: make vchiq_platform_init static Jiapeng Chong
2022-06-06 5:54 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).