From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8007BC43334 for ; Mon, 6 Jun 2022 13:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U1eyREJPsV7QEmcPCB96Ivo7iZlMsGaCzi1DQ9PlJlY=; b=Yg4DTmQQxV2KjB R80MYmQsWCMTUsEuGYoROCDjGKlK9m+nPoifcXqYvS446PES+Lm/2Z91tnBdkHTEw36p4uW+ixlWp zmcgGMhf+wu+K9h0OYumdB2I6c9Q+EAO5JQru+oDeSF8zH27bBRXaOaDj0SvIi/AvfH4Z5sUSlTnp 326vRpv9nUnw/hDtRxXccelPfqPK8Ex1vxzyYoyOtv2ncUCEpyvooxY92uab4AQthCQKM7eBFlUqW U6miBRu9PVjMPm6Q7izfcbKBQMWoUPDfrEtVhj8CwiSWz2sM2bGzg6y2Shq3PYuKHZj23gIQ4sJOr eT5n1yNyxsJS9Q1GOJSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCpu-001Mz2-0i; Mon, 06 Jun 2022 13:32:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCpq-001MxP-HQ; Mon, 06 Jun 2022 13:32:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 429A71596; Mon, 6 Jun 2022 06:31:56 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DDAB3F73B; Mon, 6 Jun 2022 06:31:54 -0700 (PDT) Date: Mon, 6 Jun 2022 14:31:48 +0100 From: Cristian Marussi To: Michael Riesch Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner , Liang Chen , Kever Yang , Jeffy Chen , Peter Geis , Nicolas Frattaroli , Etienne Carriere , Sudeep Holla Subject: Re: [PATCH] firmware: arm_scmi: Relax BASE protocol sanity checks on protocol list Message-ID: References: <20220523171559.472112-1-cristian.marussi@arm.com> <45bf11a8-47eb-e088-ba99-30c8788c7143@wolfvision.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <45bf11a8-47eb-e088-ba99-30c8788c7143@wolfvision.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_063158_668639_DA77DDEB X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 06, 2022 at 02:59:10PM +0200, Michael Riesch wrote: > Hi Cristian, > Hi Michael, > On 5/23/22 19:15, Cristian Marussi wrote: > > Even though malformed replies from firmware must be treated carefully to > > avoid memory corruption Kernel side, some out-of-spec SCMI replies can > > be tolerated to avoid breaking existing deployed system, as long as they > > won't cause memory issues. > > > > Reported-by: Nicolas Frattaroli > > Cc: Etienne Carriere > > Cc: Sudeep Holla > > Signed-off-by: Cristian Marussi > > Thanks a lot, without this fix the Mali G52 GPU won't probe on my RK3568 > EVB1 in vanilla v5.19-rc1. > Yes, the break was reported on -next and today it appeared in 5.19-rc1. A proper FW fix is also up for review by Etienne but in the meantime this tries to limit damages relaxing a bit the checks. > I guess this patch should have a Fixes: tag, right? > It has not a Fixes tag because the issue was introduced in 5.19-rc1 and the fix will go in with the next round of v5.19 fixes by Sudeep (AFAIU) so it will be solved within the v5.19 cycle and I thought the Fixes tag was not needed in this case (I could be wrong...) > Would be great to have this in v5.19. AFAIC: > > Acked-by: Michael Riesch Thanks for testing it. Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel