From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28112C43334 for ; Mon, 6 Jun 2022 21:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/VnAXAWa5f4owbA+Vpj5cq4yc7bPWou+rz+hl+uSQyQ=; b=Hex555+hhC1KJW oXWDe0RiFhjD9bCOe2WF+msOOelrm9JReAmuLKgQ3h7OHQySzcCcK/FZv2PypwIGs2sHY/rEmUCW7 IqE1TGawsw0qx2ntuvq2M4rVRskDf1koYuDRacNg6v5LxeJpO5aR8QTGdkjXUuQP3eqnFtHj2e/SO LhP99nCDGZDTIcD96GBjP2/HtHMndyVmnBYD4KEEi1CBH53eOzEIIzP0dahuv5sd7zc4SPLa1831B XYr4pFqoB/uawnZ3sYfFmokM7eIHBQ2Ro0dUhIoLMJIjyBXoQs31bRMEUVhPHznAExdqXtZXCet3H u6baTr474ULx4+WypZPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyJyX-002pW0-93; Mon, 06 Jun 2022 21:09:25 +0000 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyJyT-002pVM-Hr for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 21:09:23 +0000 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-f16a3e0529so20723860fac.2 for ; Mon, 06 Jun 2022 14:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KjZUeR41V+hdVlsqMk8d6AC7MYE0tWAvsjnkRUTqWy0=; b=pFvU4CCOoui9Xxwvj+qmAzvOiXI5aFvbgInYPFz5KR8vAZcLHD+eEK+zBnSYabG76Y MRbf1UnC8j/xo4HYq+uQIv7B4Yo4XSCQVBFX4QN+29ohKySkRHLH8O6dLfXIRcEhoZHk F+kZ7/hlhRgAU6+FKMAK4AcL0Zy1S2foyOzvqfUfQP4ii2fFfQPSFElUi+vip+WNdGs2 aJy5/A7s8iEQiAMgum4CAooOH52UZzohQgmE3lxqlDPwx39Z0rbT1T65u5ahuNxZgHri XpAhd6N9EMVKAo2hPVj7k5YB+vDf1PNUK2WXKIL44ij8uok/rG3Qeu7OsWtHTFwEkoJ5 kWTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KjZUeR41V+hdVlsqMk8d6AC7MYE0tWAvsjnkRUTqWy0=; b=YGgnuCnx+JtpcqHOzYDaw/5A0jIfN7+c3ZjD1gnVi9j8yEGfYk9DRC/rHXJWuRl2IW 3kKOTV6xXmFzOtN+OugwcMDZnczVK2iCEN4cex9a6UU+3elzC8z0/BAPSzZKr+TEzzZ2 PKosG5LZCnKXlONnn1HPHQ9GEE7K3tScEXsww5h7LRU97qkgXRixQhpI7s41loh9oa9F GEav1urmkJXZAk0KTx/POlL78syqH2Tqae6uaoA0itDXX5Xbl/kXSpzR+o6Csg+48atr r1xHR3yMfuX30dIbTI8wQ1l/0R8XPb/fEG/6vXpmfVOEH2jPDdJU9fuoagwQJxo7PG/g fnHQ== X-Gm-Message-State: AOAM533qQFMiMMd1UdpUkScU3LAkGPAo7Tt9QP5K5X/VbrxltYo3hHkN YCvzS4XWCHjSQh2dtsZiygKSGgqp17/zTg== X-Google-Smtp-Source: ABdhPJyFpCdTs573Aa9BUetYgzmOYdpif+0Pijgsdtagi9smmxL5Z1AK44PHxIkjGftSEl++FYBRGQ== X-Received: by 2002:a05:6870:b14c:b0:fa:e853:9a7e with SMTP id a12-20020a056870b14c00b000fae8539a7emr9763440oal.186.1654549757512; Mon, 06 Jun 2022 14:09:17 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q28-20020a05683022dc00b0060c00c3fde5sm1108100otc.72.2022.06.06.14.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 14:09:16 -0700 (PDT) Date: Mon, 6 Jun 2022 14:11:41 -0700 From: Bjorn Andersson To: Krzysztof Kozlowski Cc: Andy Gross , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring Subject: Re: [PATCH v4 1/4] dt-bindings: interconnect: qcom,sdm845-cpu-bwmon: add BWMON device Message-ID: References: <20220601101140.170504-1-krzysztof.kozlowski@linaro.org> <20220601101140.170504-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220601101140.170504-2-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_140921_647230_891C04E9 X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 01 Jun 03:11 PDT 2022, Krzysztof Kozlowski wrote: > Add bindings for the Qualcomm Bandwidth Monitor device providing > performance data on interconnects. The bindings describe only BWMON > version 4, e.g. the instance on SDM845 between CPU and Last Level Cache > Controller. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Rob Herring > Acked-by: Georgi Djakov > --- > .../interconnect/qcom,sdm845-cpu-bwmon.yaml | 97 +++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml > new file mode 100644 > index 000000000000..8c82e06ee432 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interconnect/qcom,sdm845-cpu-bwmon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Interconnect Bandwidth Monitor > + > +maintainers: > + - Krzysztof Kozlowski > + > +description: > + Bandwidth Monitor measures current throughput on buses between various NoC > + fabrics and provides information when it crosses configured thresholds. > + > +properties: > + compatible: > + enum: > + - qcom,sdm845-cpu-bwmon # BWMON v4 It seems the thing that's called bwmon v4 is compatible with a number of different platforms, should we add a generic compatible to the binding as well, to avoid having to update the implementation for each SoC? (I.e. "qcom,sdm845-cpu-bwmon", "qcom,bwmon-v4") Regards, Bjorn > + > + interconnects: > + maxItems: 2 > + > + interconnect-names: > + items: > + - const: ddr > + - const: l3c > + > + interrupts: > + maxItems: 1 > + > + operating-points-v2: true > + opp-table: true > + > + reg: > + # Currently described BWMON v4 and v5 use one register address space. > + # BWMON v2 uses two register spaces - not yet described. > + maxItems: 1 > + > +required: > + - compatible > + - interconnects > + - interconnect-names > + - interrupts > + - operating-points-v2 > + - opp-table > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + pmu@1436400 { > + compatible = "qcom,sdm845-cpu-bwmon"; > + reg = <0x01436400 0x600>; > + > + interrupts = ; > + > + interconnects = <&gladiator_noc MASTER_APPSS_PROC 3 &mem_noc SLAVE_EBI1 3>, > + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>; > + interconnect-names = "ddr", "l3c"; > + > + operating-points-v2 = <&cpu_bwmon_opp_table>; > + > + cpu_bwmon_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-0 { > + opp-peak-kBps = <800000 4800000>; > + }; > + opp-1 { > + opp-peak-kBps = <1804000 9216000>; > + }; > + opp-2 { > + opp-peak-kBps = <2188000 11980800>; > + }; > + opp-3 { > + opp-peak-kBps = <3072000 15052800>; > + }; > + opp-4 { > + opp-peak-kBps = <4068000 19353600>; > + }; > + opp-5 { > + opp-peak-kBps = <5412000 20889600>; > + }; > + opp-6 { > + opp-peak-kBps = <6220000 22425600>; > + }; > + opp-7 { > + opp-peak-kBps = <7216000 25497600>; > + }; > + }; > + }; > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel