From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9047C433EF for ; Tue, 7 Jun 2022 15:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=//hHqREfwKO/HW6eLnrCVlbNdhYmSZhupwltZFs10uY=; b=uKz0BU512loSG3 82rpwVWaH3CsNVr0ZIEf44aHOFpeMlG/3ZYZ09naWuGlZ9l9Wvye5hnEF1ttJ5GQshXguJWGP01U4 Tckb5KO1LKCKeXWzrIslkGR19zW87mc+YWCTLY3JQwovxcrWuP52PPUXDLarUcVBKhvx3lT0sfcrM Is0YwGrDxvxm59kzHXFCWfnbfHRvd/+i5Bhj3T7eNCOxiDfsHoEHTJ3qP+aU1UIkADpfGr39v8hcG w9Mak/6rR7WPVmQK+qCBYvdaEMfIbFuH678hs2x04ieLjHwz2A/4wc/lcnsVCZysKyMr0hafx63Np Mvx2VOgsll5DPxP5MY/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyavI-008FE9-So; Tue, 07 Jun 2022 15:15:12 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyavG-008FDI-F5 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 15:15:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E216DB8206B; Tue, 7 Jun 2022 15:15:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A88EC385A5; Tue, 7 Jun 2022 15:15:06 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="neC6mfEh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1654614905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DZuHJPQiHP4rHVjD/qdEgYv2Fzx196BxBOjguVbVCcE=; b=neC6mfEhGijcPrsAFaEp7MT1Tqxd3gNX3tzHAmZ72pv84FWPUjYU3mUlIn9f8lsZYtHLFU DWnnl9jlkH8w8ueGWLB2r4jyfeNhTqWS0wUaq0JdCCJ+U0WpvzLnFjyxcqi4+0g0q3xS2T rALUtAyqQT+0KDMitJ6ob08afivWcKE= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 6746b553 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 7 Jun 2022 15:15:04 +0000 (UTC) Date: Tue, 7 Jun 2022 17:14:59 +0200 From: "Jason A. Donenfeld" To: Phil Elwell Cc: Russell King - ARM Linux , Russell King , linux-arm-kernel , LKML , Catalin Marinas , Stephen Boyd , Ard Biesheuvel , stable Subject: Re: [PATCH v2] ARM: initialize jump labels before setup_machine_fdt() Message-ID: References: <8cc7ebe4-442b-a24b-9bb0-fce6e0425ee6@raspberrypi.com> <8c3fe744-0181-043a-3af9-dd00165a6356@raspberrypi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8c3fe744-0181-043a-3af9-dd00165a6356@raspberrypi.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_081510_687063_5C8A3409 X-CRM114-Status: GOOD ( 24.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey again, On Tue, Jun 07, 2022 at 10:15:27AM +0100, Phil Elwell wrote: > On 07/06/2022 09:43, Jason A. Donenfeld wrote: > > Hi Phil, > > > > On Tue, Jun 7, 2022 at 10:29 AM Phil Elwell wrote: > >> > >> This patch is fatal for me in the downstream Raspberry Pi kernel - it locks up > >> on boot even before the earlycon output is available. Hacking jump_label_init to > >> skip the jump_entry for "crng_is_ready" allows it to boot, but is likely to have > >> consequences further down the line. > > > > Also, reading this a few times, I'm not 100% sure I understand what > > you did to hack around this and why that works. Think you could paste > > your hackpatch just out of interest to the discussion (but obviously > > not to be applied)? > > This is the minimal version of my workaround patch that at least allows the > board to boot. Bear in mind that it was written with no previous knowledge of > jump labels and was arrived at by iteratively bisecting the list of jump_labels > until the first dangerous one was found, then later working out that there was > only one. Looks like this patch fails due to CONFIG_STRICT_KERNEL_RWX. Investigating deeper now, but that for starters seems to be the differentiating factor between my prior test rig and one that reproduces the error. I assume your raspi also sets CONFIG_STRICT_KERNEL_RWX. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel