From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: James Clark <james.clark@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
broonie@kernel.org, german.gomez@arm.com,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v1 4/6] perf tools: Use dynamic register set for Dwarf unwind
Date: Fri, 27 May 2022 13:08:43 -0300 [thread overview]
Message-ID: <YpD3i2prgA8ESb7Q@kernel.org> (raw)
In-Reply-To: <20220527061854.GA829807@leoy-ThinkPad-X240s>
Em Fri, May 27, 2022 at 02:18:54PM +0800, Leo Yan escreveu:
> On Thu, May 26, 2022 at 03:19:54PM -0300, Arnaldo Carvalho de Melo wrote:
>
> [...]
>
> > Too old to support?
> >
> > 69 7.19 ubuntu:16.04-x-arm64 : FAIL gcc version 5.4.0 20160609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9)
> > arch/arm64/util/perf_regs.c: In function 'arch__user_reg_mask':
> > arch/arm64/util/perf_regs.c:151:28: error: 'HWCAP_SVE' undeclared (first use in this function)
> > if (getauxval(AT_HWCAP) & HWCAP_SVE)
> > ^
> > arch/arm64/util/perf_regs.c:151:28: note: each undeclared identifier is reported only once for each function it appears in
> > /git/perf-5.18.0/tools/build/Makefile.build:139: recipe for target 'util' failed
> > make[5]: *** [util] Error 2
> > /git/perf-5.18.0/tools/build/Makefile.build:139: recipe for target 'arm64' failed
> > make[4]: *** [arm64] Error 2
> > /git/perf-5.18.0/tools/build/Makefile.build:139: recipe for target 'arch' failed
> > make[3]: *** [arch] Error 2
> >
> >
> > ⬢[acme@toolbox perf]$ find . -name "*.h" | xargs grep -w HWCAP_SVE
> > ./arch/arm64/include/uapi/asm/hwcap.h:#define HWCAP_SVE (1 << 22)
> > ⬢[acme@toolbox perf]$
>
> I tested aarch64 GCC-7.4.1 which doesn't support HWCAP_SVE, but
> aarch64 GCC-8.3.0 and GCC-9.4.0 support it.
>
> Either we can add below code:
>
> #ifndef HWCAP_SVE
> #define HWCAP_SVE (1 << 22)
> #endif
>
> Or directly include header file <.../asm/hwcap.h>.
>
> Not sure which method is preferred. Maybe the first approach can be
> de-couple with Linux kernel code?
Lets go KISS and just define it if not present, as you suggested above,
will test now.
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-27 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 14:42 [PATCH v1 0/6] perf: arm64: Support for Dwarf unwinding through SVE functions James Clark
2022-05-09 14:42 ` [PATCH v1 1/6] perf: arm64: Add SVE vector granule register to user regs James Clark
2022-05-09 15:48 ` Mark Brown
2022-05-10 9:34 ` James Clark
2022-05-09 14:42 ` [PATCH v1 2/6] arm64/sve: Add Perf extensions documentation James Clark
2022-05-09 15:45 ` Mark Brown
2022-05-09 14:42 ` [PATCH v1 3/6] perf tools: arm64: Copy perf_regs.h from the kernel James Clark
2022-05-09 14:42 ` [PATCH v1 4/6] perf tools: Use dynamic register set for Dwarf unwind James Clark
2022-05-26 15:44 ` Arnaldo Carvalho de Melo
2022-05-26 18:19 ` Arnaldo Carvalho de Melo
2022-05-27 6:18 ` Leo Yan
2022-05-27 16:08 ` Arnaldo Carvalho de Melo [this message]
2022-05-09 14:42 ` [PATCH v1 5/6] perf tools: arm64: Decouple Libunwind register names from Perf James Clark
2022-05-09 14:42 ` [PATCH v1 6/6] perf tools: arm64: Add support for VG register James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpD3i2prgA8ESb7Q@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=broonie@kernel.org \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).