From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0361AC433EF for ; Tue, 31 May 2022 01:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IVOCfs56dGraobUkUZmrsLLnDK8ETShff7mW68tp9jA=; b=Ayi6+FR5cpLK/I Ne5ZEJ1TGZ1kAY22sctj0moDIqaaKPa4LeQTAzTgByZw9ro72zSky/r0inaH3XmFbeZwI3uYxZZIQ /aT9lcfIEzIgkGg5IE15LCbUSbh0K9Xq0pz0iP5nznGuKgt9EKzgxE5VJfByvqITKdJ4NQDg1pZSc umS+O4fjeKEbYjWpP8qCBfrpgWN6KYMqHIpIjmkPCOYTqfjqtVY5qz9uaHpNRZYqyJrRvJRrkoTED 8132Lf0RgZYPL774DIQ+IeYuAbzmP0UbJ1Bt9V62YwqqbXvUbIrsKGpVshIwBDh2J+yCG12E8zpFF EHkW974EsE4Y9IWQK5pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvr8q-008tkZ-Vm; Tue, 31 May 2022 01:57:53 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvr8n-008tjN-2l; Tue, 31 May 2022 01:57:50 +0000 Received: by mail-pl1-x62b.google.com with SMTP id i1so11611022plg.7; Mon, 30 May 2022 18:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H1ALc2KclO05GRseCzU2tE4hpTR2Pi5sFXcUIZRtWsA=; b=nkg6VtSJWfIsQTK9CgwNVULu5G6bwGzzn9A5VzEeP7noKoColCe6jkyWHlX07QFT9a dWL8KXCS7wo5UPHNUS6jpGAS4zMJm6FY+SAFjP75kT99T/i7OHdX4NmD3EPWrZhMcm/W I0bKq++5lbMB7mLnN72GHIE4vUCigvAonIak84pCla18pl43f0YxdisSOKfaryCtuoLH iDlMV2PNN1ndtfc19tkAlOyhHj2ZCVpQAvwJVSi/an3hr9wCkg+kk5femcVzqeNPczTh qeHUcUSh4Q9ZCJVTXST4GJhYXl6R6kzTfsWfsBFt5VDYBLGIv99o7TrBusId5sFxvK/o y6fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H1ALc2KclO05GRseCzU2tE4hpTR2Pi5sFXcUIZRtWsA=; b=h4nnmgPnY5T+3wy61ib83cDfqLF6fMQ2gqZUpxd0njCzqreIihDP742YrOqrYhxWFG 9fHqfpnljn9VHS/Uj45whDolz6+uk8W2wUy3kcs1GLB0viDVCGbu9if2OwYHXdJNqh/B qaCrJiVE87qr/pSYPH5IfFGWcSflUV1cwG8EDOV/q+c59P0IMGeQCg9rBmpUNA8PngnV k6XAD2T9vN1Osgc0P7d9P17oUX0dH9f5dpoe3B+0kEHvIIV1U52v8g+ZtOT7fxsTiz4m oXw9SgPP3SmslV9AGP7NPkOkyNc8z87l8wQdOujv7rGq0BbgOivTcItRQlEvhppSQYaa +tNA== X-Gm-Message-State: AOAM530ORHLZyM8xA68foEptPaYAs2ps/ixmZjgkeBZNgMaembvBrQ1D lODZccPRSfQaEVEStTohktM= X-Google-Smtp-Source: ABdhPJwdpGnajHkcJbGWtfM8aj7t5A5jw2tSO0CVE0zmMWS2r9LENG0uH1TBhjzoec6IN5FPItXKLg== X-Received: by 2002:a17:90b:224e:b0:1e2:754d:aeb with SMTP id hk14-20020a17090b224e00b001e2754d0aebmr22290797pjb.220.1653962267856; Mon, 30 May 2022 18:57:47 -0700 (PDT) Received: from google.com ([2620:15c:202:201:fc02:c347:e06e:9518]) by smtp.gmail.com with ESMTPSA id r10-20020a170902ea4a00b00163cf7023edsm3738990plg.243.2022.05.30.18.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 18:57:46 -0700 (PDT) Date: Mon, 30 May 2022 18:57:44 -0700 From: Dmitry Torokhov To: Randy Dunlap Cc: Charles Mirabile , linux-kernel@vger.kernel.org, Serge Schneider , Stefan Wahren , Nicolas Saenz Julienne , Mattias Brugger , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, fedora-rpi@googlegroups.com, linux-input@vger.kernel.org, Daniel Bauman , Mwesigwa Guma , Joel Savitz Subject: Re: [PATCH v9 2/6] drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver Message-ID: References: <20220419205158.28088-1-cmirabil@redhat.com> <20220419205158.28088-3-cmirabil@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220530_185749_163017_02FC2D5D X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Randy, On Mon, May 30, 2022 at 06:26:26PM -0700, Randy Dunlap wrote: > Hi-- > > On 4/19/22 13:51, Charles Mirabile wrote: > > diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig > > index 3b23078bc7b5..505a032e2786 100644 > > --- a/drivers/input/joystick/Kconfig > > +++ b/drivers/input/joystick/Kconfig > > @@ -399,4 +399,15 @@ config JOYSTICK_N64 > > Say Y here if you want enable support for the four > > built-in controller ports on the Nintendo 64 console. > > > > +config JOYSTICK_SENSEHAT > > + tristate "Raspberry Pi Sense HAT joystick" > > + depends on INPUT && I2C > > + select MFD_SIMPLE_MFD_I2C > > Looks like this also needs > depends on HAS_IOMEM > > since everything in drivers/mfd/Kconfig depends on HAS_IOMEM and > since this 'select' causes a kconfig warning when HAS_IOMEM is not set: > > WARNING: unmet direct dependencies detected for MFD_SIMPLE_MFD_I2C > Depends on [n]: HAS_IOMEM [=n] && I2C [=y] > Selected by [y]: > - JOYSTICK_SENSEHAT [=y] && INPUT_JOYSTICK [=y] && INPUT [=y] && I2C [=y] Do you mind sending a patch? Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel