From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38287C433EF for ; Tue, 31 May 2022 17:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UYJ9M+APHVXCkRzodyKCis7dCa2CEtYLbfTkWqTPLjE=; b=k0f9ZcrMqLRq4D IZLrL7Qeox+0SfrIJSDFMBTxLnCrqEjhzp21nzSIjA2llFE3btL9TerpbfpVeES/0aJt8jRc6ydov cTOQ6YTPLp+i+YW9Jcx3VA+mUP9sZI4gfHr/PIjReDGVg6HzMIySubtkl//T0PwRCnBTDkTqNjFPr y+iQXjIN8b0TBiDzC2i26QBPaABwoBLMKRAtWtV3hPghyG8mXclDfnhvHRWZfiCzoHZ/eiiRYEOul SeOrHOrrv1ufI6ma6rAemWrsNwxW5Qgk/sKZcuUCY9B9+RUNZJCSTXwYTj4SRwMhI5FTo1dVdZthW capkMU3ove0zjoaOLMDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw5sI-00C5BI-QJ; Tue, 31 May 2022 17:41:46 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw5sE-00C59u-Td for linux-arm-kernel@lists.infradead.org; Tue, 31 May 2022 17:41:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1654018902; x=1685554902; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=P69t0B2Jaz9Oq6WPSoVJEBxSVVjv0VZ1WwYPpxNmfU4=; b=bXnLJyf/ZFLBAHT4qSjyRBiOnDdDPvwa9goDK3RkLIQKsibnFZk/ZI6/ 3To1XOKu0K9vdqbmKgJDTco/8mgcuqjnoA2EK8UM+ipGqjIDLMWeGHxTX wfuVUr5oYlwz51syAMV0OF1jcAt958G4wVsU/U70wcHwjmB3Ngk0APSHr 0=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 31 May 2022 10:41:35 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 10:41:35 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 31 May 2022 10:41:34 -0700 Received: from qian (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 31 May 2022 10:41:33 -0700 Date: Tue, 31 May 2022 13:41:31 -0400 From: Qian Cai To: Will Deacon CC: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , , , Subject: Re: [PATCH] KVM: arm64: Fix memory leaks from stage2 pagetable Message-ID: References: <20220526203956.143873-1-quic_qiancai@quicinc.com> <20220531165710.GB25631@willie-the-truck> <20220531170157.GC25631@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220531170157.GC25631@willie-the-truck> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_104143_021850_357B8D08 X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 31, 2022 at 06:01:58PM +0100, Will Deacon wrote: > Have you spotted any pattern for when the leak occurs? How are you > terminating the guest? It just to send a SIGTERM to the qemu-system-aarch64 process. Origially, right after sending the signal, it will remove_id/unbind from the vfio-pci and then bind to the original (ixgbe) driver. However, since the process might take a while to clean off itself, the bind might failed with -EBUSY. I could reproduce it a few times one day while was unable to do so some other days. Later, we changed the code to make sure the process is disappeard first and then remove_id/bind/unbind. Apparently, it make harder to reproduce if not totally eliminate it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel