From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B998C433EF for ; Thu, 9 Jun 2022 17:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s7enEfo1dZOPGQBg9NAIqi9X3T1JdLE+G14DnuI7980=; b=jcB+4A7YZCqTN/ BF0m8baVOWBROXGbVkCOHQ2q9CYfVqNnESx3AvWPOvSHBQuAtqgxarY11SAw4YQM6jv3/UgPZTdZc Vm6i0NZw0apxf9dsDodzgk9wxeY484EOxTmybDWOHWPJhsbE5Z/55xfaOxWP3xLLmvwzMoryROExo QLjT5n7gWB4d3KxtjtfslIOp4ziO3+UAfdMVCYYSsI3eo3yOFaKWrO81OYAE4ueO3cWzG6dwwo69p LCVHEX6XWiipPUij8IIZZJc6PsZS9XZ9ZhQYkciYhmWaZEL5A19qW30+36RFF8wXPYosCSS1oPhtD cS2+RckuBsr/qFuEJNnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzMOR-003NxK-O2; Thu, 09 Jun 2022 17:56:27 +0000 Received: from out0.migadu.com ([94.23.1.103]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzMOO-003Nsb-GO for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2022 17:56:26 +0000 Date: Thu, 9 Jun 2022 10:56:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1654797378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rnz2K2i3sOABjcYz20JocfHMNMQmCmpt0izotfrjuZE=; b=j67AOKPWQZyeQS+DeTeQuRDCfaY/8eqKGeUy1H2zcMJDvHMZ1bY+ozG1F+9aDgFxDAwdG3 1jmuYudpBlTmQ01sl8S/rN5C524OkNZSYC0+tRoELIWkQNNhr3oPJ4mbEHp6wXD9lnJZ8l TnTT8UgAnnC6PdJYB2XoMlkbZyQMk08= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Naresh Kamboju , Linux-Next Mailing List , open list , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, Linux ARM , linux-mm , Stephen Rothwell , Andrew Morton , Ard Biesheuvel , Arnd Bergmann , Catalin Marinas , Raghuram Thammiraju , Mark Brown , Will Deacon , Vasily Averin , Qian Cai Subject: Re: [next] arm64: boot failed - next-20220606 Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_105624_724989_4E26B980 X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 09, 2022 at 10:47:35AM -0700, Shakeel Butt wrote: > On Thu, Jun 9, 2022 at 10:27 AM Roman Gushchin wrote: > > > [...] > > +struct mem_cgroup *mem_cgroup_from_obj(void *p) > > +{ > > + struct folio *folio; > > + > > + if (mem_cgroup_disabled()) > > + return NULL; > > + > > + if (unlikely(is_vmalloc_addr(p))) > > + folio = page_folio(vmalloc_to_page(p)); > > Do we need to check for NULL from vmalloc_to_page(p)? Idk, can it realistically return NULL after is_vmalloc_addr() returned true? I would be surprised, but maybe I'm missing something. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel